forked from desktop/desktop
-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add missing MIME type to AppImage package #496
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Building: add missing MIME tyrpe
fixes the final CI failing
shiftkey
approved these changes
May 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for finding this @Mrlinkwii - I'd forgotten to check here when I applied this to the DEB and RPM installers at the time!
I'm going to merge this and cut a new release tomorrow so we can confirm this is resolved...
shiftkey
changed the title
add missing MIME type
add missing MIME type to AppImage package
May 8, 2021
shiftkey
pushed a commit
that referenced
this pull request
May 8, 2021
shiftkey
pushed a commit
that referenced
this pull request
May 9, 2021
shiftkey
pushed a commit
that referenced
this pull request
May 25, 2021
shiftkey
pushed a commit
that referenced
this pull request
May 27, 2021
shiftkey
pushed a commit
that referenced
this pull request
May 28, 2021
shiftkey
pushed a commit
that referenced
this pull request
May 28, 2021
shiftkey
pushed a commit
that referenced
this pull request
Jun 7, 2021
shiftkey
pushed a commit
that referenced
this pull request
Jun 7, 2021
shiftkey
pushed a commit
that referenced
this pull request
Jun 7, 2021
shiftkey
pushed a commit
that referenced
this pull request
Jun 7, 2021
shiftkey
pushed a commit
that referenced
this pull request
Jun 10, 2021
shiftkey
pushed a commit
that referenced
this pull request
Jun 10, 2021
shiftkey
pushed a commit
that referenced
this pull request
Jun 13, 2021
shiftkey
pushed a commit
that referenced
this pull request
Jun 16, 2021
shiftkey
pushed a commit
that referenced
this pull request
Jun 16, 2021
shiftkey
pushed a commit
that referenced
this pull request
Jun 16, 2021
shiftkey
pushed a commit
that referenced
this pull request
Jun 22, 2021
shiftkey
pushed a commit
that referenced
this pull request
Jun 30, 2021
shiftkey
pushed a commit
that referenced
this pull request
Jun 30, 2021
shiftkey
pushed a commit
that referenced
this pull request
Jul 3, 2021
shiftkey
pushed a commit
that referenced
this pull request
Jul 19, 2021
shiftkey
pushed a commit
that referenced
this pull request
Jul 22, 2021
shiftkey
pushed a commit
that referenced
this pull request
Aug 13, 2021
shiftkey
pushed a commit
that referenced
this pull request
Jun 2, 2024
shiftkey
pushed a commit
that referenced
this pull request
Jun 2, 2024
shiftkey
pushed a commit
that referenced
this pull request
Jul 1, 2024
shiftkey
pushed a commit
that referenced
this pull request
Jul 1, 2024
shiftkey
pushed a commit
that referenced
this pull request
Jul 1, 2024
shiftkey
pushed a commit
that referenced
this pull request
Jul 1, 2024
shiftkey
pushed a commit
that referenced
this pull request
Jul 1, 2024
shiftkey
pushed a commit
that referenced
this pull request
Jul 1, 2024
shiftkey
pushed a commit
that referenced
this pull request
Jul 1, 2024
shiftkey
pushed a commit
that referenced
this pull request
Jul 13, 2024
shiftkey
pushed a commit
that referenced
this pull request
Aug 10, 2024
shiftkey
pushed a commit
that referenced
this pull request
Aug 10, 2024
shiftkey
pushed a commit
that referenced
this pull request
Aug 10, 2024
shiftkey
pushed a commit
that referenced
this pull request
Aug 11, 2024
shiftkey
pushed a commit
that referenced
this pull request
Aug 11, 2024
shiftkey
pushed a commit
that referenced
this pull request
Aug 11, 2024
shiftkey
pushed a commit
that referenced
this pull request
Aug 11, 2024
shiftkey
pushed a commit
that referenced
this pull request
Aug 11, 2024
shiftkey
pushed a commit
that referenced
this pull request
Aug 11, 2024
shiftkey
pushed a commit
that referenced
this pull request
Aug 11, 2024
shiftkey
added a commit
that referenced
this pull request
Aug 11, 2024
shiftkey
added a commit
that referenced
this pull request
Aug 11, 2024
shiftkey
added a commit
that referenced
this pull request
Aug 11, 2024
shiftkey
added a commit
that referenced
this pull request
Aug 11, 2024
shiftkey
added a commit
that referenced
this pull request
Aug 11, 2024
shiftkey
added a commit
that referenced
this pull request
Aug 14, 2024
shiftkey
added a commit
that referenced
this pull request
Aug 15, 2024
shiftkey
added a commit
that referenced
this pull request
Aug 17, 2024
shiftkey
added a commit
that referenced
this pull request
Aug 17, 2024
shiftkey
added a commit
that referenced
this pull request
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it should close #416 in terms of appimages
Description
-adds missing MIME type to the electron builder ,
x-scheme-handler/x-github-desktop-dev-auth
which is mentioned in the red-hat builder and debian builder but not the electron builderdesktop/script/package-debian.ts
Lines 67 to 74 in e2e0483
desktop/script/package-redhat.ts
Lines 65 to 71 in e2e0483
what made me look at this was #416 (comment)
Screenshots
N/A
Release notes
Notes:no-notes