forked from desktop/desktop
-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
patch electron-installer-redhat
to disable .build-id
links in directory
#837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shiftkey
changed the title
Manually patch redhat installer
patch Feb 20, 2023
electron-installer-redhat
to disable .build-id
links in directory
shiftkey
added a commit
that referenced
this pull request
Feb 26, 2023
…ectory (#837) * add patch-package so we can patch a node_modules package * generate patch to disable build-id contents for RPM package * move patch-package command to post-install script * regenerate patch file
shiftkey
added a commit
that referenced
this pull request
Feb 26, 2023
…ectory (#837) * add patch-package so we can patch a node_modules package * generate patch to disable build-id contents for RPM package * move patch-package command to post-install script * regenerate patch file
shiftkey
added a commit
that referenced
this pull request
Feb 26, 2023
…ectory (#837) * add patch-package so we can patch a node_modules package * generate patch to disable build-id contents for RPM package * move patch-package command to post-install script * regenerate patch file
shiftkey
added a commit
that referenced
this pull request
Mar 1, 2023
…ectory (#837) * add patch-package so we can patch a node_modules package * generate patch to disable build-id contents for RPM package * move patch-package command to post-install script * regenerate patch file
shiftkey
added a commit
that referenced
this pull request
Mar 1, 2023
…ectory (#837) * add patch-package so we can patch a node_modules package * generate patch to disable build-id contents for RPM package * move patch-package command to post-install script * regenerate patch file
shiftkey
added a commit
that referenced
this pull request
Mar 1, 2023
…ectory (#837) * add patch-package so we can patch a node_modules package * generate patch to disable build-id contents for RPM package * move patch-package command to post-install script * regenerate patch file
shiftkey
added a commit
that referenced
this pull request
Mar 2, 2023
…ectory (#837) * add patch-package so we can patch a node_modules package * generate patch to disable build-id contents for RPM package * move patch-package command to post-install script * regenerate patch file
shiftkey
added a commit
that referenced
this pull request
Mar 15, 2023
…ectory (#837) * add patch-package so we can patch a node_modules package * generate patch to disable build-id contents for RPM package * move patch-package command to post-install script * regenerate patch file
shiftkey
added a commit
that referenced
this pull request
Apr 4, 2023
…ectory (#837) * add patch-package so we can patch a node_modules package * generate patch to disable build-id contents for RPM package * move patch-package command to post-install script * regenerate patch file
shiftkey
added a commit
that referenced
this pull request
Apr 7, 2023
…ectory (#837) * add patch-package so we can patch a node_modules package * generate patch to disable build-id contents for RPM package * move patch-package command to post-install script * regenerate patch file
shiftkey
added a commit
that referenced
this pull request
Apr 7, 2023
…ectory (#837) * add patch-package so we can patch a node_modules package * generate patch to disable build-id contents for RPM package * move patch-package command to post-install script * regenerate patch file
shiftkey
added a commit
that referenced
this pull request
Apr 7, 2023
…ectory (#837) * add patch-package so we can patch a node_modules package * generate patch to disable build-id contents for RPM package * move patch-package command to post-install script * regenerate patch file
I am currently getting errors with this change implemented on armhf linux. Any ideas what they mean?
|
theofficialgman
pushed a commit
to theofficialgman/desktop
that referenced
this pull request
Jun 4, 2023
…ectory (shiftkey#837) * add patch-package so we can patch a node_modules package * generate patch to disable build-id contents for RPM package * move patch-package command to post-install script * regenerate patch file
shiftkey
added a commit
that referenced
this pull request
Jun 5, 2023
…ectory (#837) * add patch-package so we can patch a node_modules package * generate patch to disable build-id contents for RPM package * move patch-package command to post-install script * regenerate patch file
shiftkey
added a commit
that referenced
this pull request
Jun 5, 2023
…ectory (#837) * add patch-package so we can patch a node_modules package * generate patch to disable build-id contents for RPM package * move patch-package command to post-install script * regenerate patch file
shiftkey
added a commit
that referenced
this pull request
Jul 3, 2023
…ectory (#837) * add patch-package so we can patch a node_modules package * generate patch to disable build-id contents for RPM package * move patch-package command to post-install script * regenerate patch file
shiftkey
added a commit
that referenced
this pull request
Jul 3, 2023
…ectory (#837) * add patch-package so we can patch a node_modules package * generate patch to disable build-id contents for RPM package * move patch-package command to post-install script * regenerate patch file
shiftkey
added a commit
that referenced
this pull request
Jul 3, 2023
…ectory (#837) * add patch-package so we can patch a node_modules package * generate patch to disable build-id contents for RPM package * move patch-package command to post-install script * regenerate patch file
shiftkey
added a commit
that referenced
this pull request
Jul 3, 2023
…ectory (#837) * add patch-package so we can patch a node_modules package * generate patch to disable build-id contents for RPM package * move patch-package command to post-install script * regenerate patch file
shiftkey
added a commit
that referenced
this pull request
Jul 1, 2024
…ectory (#837) * add patch-package so we can patch a node_modules package * generate patch to disable build-id contents for RPM package * move patch-package command to post-install script * regenerate patch file
shiftkey
added a commit
that referenced
this pull request
Jul 13, 2024
…ectory (#837) * add patch-package so we can patch a node_modules package * generate patch to disable build-id contents for RPM package * move patch-package command to post-install script * regenerate patch file
shiftkey
added a commit
that referenced
this pull request
Aug 10, 2024
…ectory (#837) * add patch-package so we can patch a node_modules package * generate patch to disable build-id contents for RPM package * move patch-package command to post-install script * regenerate patch file
shiftkey
added a commit
that referenced
this pull request
Aug 10, 2024
…ectory (#837) * add patch-package so we can patch a node_modules package * generate patch to disable build-id contents for RPM package * move patch-package command to post-install script * regenerate patch file
shiftkey
added a commit
that referenced
this pull request
Aug 10, 2024
…ectory (#837) * add patch-package so we can patch a node_modules package * generate patch to disable build-id contents for RPM package * move patch-package command to post-install script * regenerate patch file
shiftkey
added a commit
that referenced
this pull request
Aug 11, 2024
…ectory (#837) * add patch-package so we can patch a node_modules package * generate patch to disable build-id contents for RPM package * move patch-package command to post-install script * regenerate patch file
shiftkey
added a commit
that referenced
this pull request
Aug 11, 2024
…ectory (#837) * add patch-package so we can patch a node_modules package * generate patch to disable build-id contents for RPM package * move patch-package command to post-install script * regenerate patch file
shiftkey
added a commit
that referenced
this pull request
Aug 11, 2024
…ectory (#837) * add patch-package so we can patch a node_modules package * generate patch to disable build-id contents for RPM package * move patch-package command to post-install script * regenerate patch file
shiftkey
added a commit
that referenced
this pull request
Aug 11, 2024
…ectory (#837) * add patch-package so we can patch a node_modules package * generate patch to disable build-id contents for RPM package * move patch-package command to post-install script * regenerate patch file
shiftkey
added a commit
that referenced
this pull request
Aug 11, 2024
…ectory (#837) * add patch-package so we can patch a node_modules package * generate patch to disable build-id contents for RPM package * move patch-package command to post-install script * regenerate patch file
shiftkey
added a commit
that referenced
this pull request
Aug 11, 2024
…ectory (#837) * add patch-package so we can patch a node_modules package * generate patch to disable build-id contents for RPM package * move patch-package command to post-install script * regenerate patch file
shiftkey
added a commit
that referenced
this pull request
Aug 11, 2024
…ectory (#837) * add patch-package so we can patch a node_modules package * generate patch to disable build-id contents for RPM package * move patch-package command to post-install script * regenerate patch file
shiftkey
added a commit
that referenced
this pull request
Aug 11, 2024
…ectory (#837) * add patch-package so we can patch a node_modules package * generate patch to disable build-id contents for RPM package * move patch-package command to post-install script * regenerate patch file
shiftkey
added a commit
that referenced
this pull request
Aug 11, 2024
…ectory (#837) * add patch-package so we can patch a node_modules package * generate patch to disable build-id contents for RPM package * move patch-package command to post-install script * regenerate patch file
shiftkey
added a commit
that referenced
this pull request
Aug 11, 2024
…ectory (#837) * add patch-package so we can patch a node_modules package * generate patch to disable build-id contents for RPM package * move patch-package command to post-install script * regenerate patch file
shiftkey
added a commit
that referenced
this pull request
Aug 11, 2024
…ectory (#837) * add patch-package so we can patch a node_modules package * generate patch to disable build-id contents for RPM package * move patch-package command to post-install script * regenerate patch file
shiftkey
added a commit
that referenced
this pull request
Aug 11, 2024
…ectory (#837) * add patch-package so we can patch a node_modules package * generate patch to disable build-id contents for RPM package * move patch-package command to post-install script * regenerate patch file
shiftkey
added a commit
that referenced
this pull request
Aug 11, 2024
…ectory (#837) * add patch-package so we can patch a node_modules package * generate patch to disable build-id contents for RPM package * move patch-package command to post-install script * regenerate patch file
shiftkey
added a commit
that referenced
this pull request
Aug 11, 2024
…ectory (#837) * add patch-package so we can patch a node_modules package * generate patch to disable build-id contents for RPM package * move patch-package command to post-install script * regenerate patch file
shiftkey
added a commit
that referenced
this pull request
Aug 11, 2024
patch `electron-installer-redhat` to disable `.build-id` links in directory (#837) * add patch-package so we can patch a node_modules package * generate patch to disable build-id contents for RPM package * move patch-package command to post-install script * regenerate patch file
shiftkey
added a commit
that referenced
this pull request
Aug 11, 2024
patch `electron-installer-redhat` to disable `.build-id` links in directory (#837) * add patch-package so we can patch a node_modules package * generate patch to disable build-id contents for RPM package * move patch-package command to post-install script * regenerate patch file
shiftkey
added a commit
that referenced
this pull request
Aug 11, 2024
* add patch-package so we can patch a node_modules package * generate patch to disable build-id contents for RPM package * move patch-package command to post-install script * regenerate patch file
shiftkey
added a commit
that referenced
this pull request
Aug 11, 2024
* add patch-package so we can patch a node_modules package * generate patch to disable build-id contents for RPM package * move patch-package command to post-install script * regenerate patch file
shiftkey
added a commit
that referenced
this pull request
Aug 12, 2024
shiftkey
added a commit
that referenced
this pull request
Aug 14, 2024
shiftkey
added a commit
that referenced
this pull request
Aug 15, 2024
shiftkey
added a commit
that referenced
this pull request
Aug 17, 2024
shiftkey
added a commit
that referenced
this pull request
Aug 17, 2024
shiftkey
added a commit
that referenced
this pull request
Sep 2, 2024
shiftkey
added a commit
that referenced
this pull request
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #796
Description
This works around the problem where multiple packages generate the same
.build-id/
directory contents, by passing in the right argument to theelectron-installer-redhat
template.Screenshots
Before:
After: no files present