Skip to content

Commit

Permalink
Remove kube_*_annotations from deny list
Browse files Browse the repository at this point in the history
Since kubernetes/kube-state-metrics#2145,
kube-state-metrics does not collect `kube_*_annotations` metrics by
default. It's no longer necessary to add them to the metrics' deny list.

Removing `kube_*_annotations` from the deny list allows us to enable
scrapping of annotation metrics via the `--metric-annotations-allowlist`
option.

Additionally, we were missing a comma, which might have been a problem
in the comma-separated list of arguments.
  • Loading branch information
mandre committed Aug 2, 2024
1 parent 491ab3b commit d379f1f
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 2 deletions.
1 change: 0 additions & 1 deletion assets/kube-state-metrics/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ spec:
- |
--metric-denylist=
^kube_secret_labels$,
^kube_.+_annotations$
^kube_customresource_.+_annotations_info$,
^kube_customresource_.+_labels_info$,
- --metric-labels-allowlist=pods=[*],nodes=[*],namespaces=[*],persistentvolumes=[*],persistentvolumeclaims=[*],poddisruptionbudgets=[*]
Expand Down
1 change: 0 additions & 1 deletion jsonnet/components/kube-state-metrics.libsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,6 @@ function(params)
|||
--metric-denylist=
^kube_secret_labels$,
^kube_.+_annotations$
^kube_customresource_.+_annotations_info$,
^kube_customresource_.+_labels_info$,
|||,
Expand Down

0 comments on commit d379f1f

Please sign in to comment.