Improve tabwin highlight #272
Conversation
This is more noticeable in dark variant and when "Cycle through windows in a list" is enabled.
| } | ||
| &:hover { | ||
| background: mix(black, $selected_bg_color, 40%); | ||
| background: transparentize($bg_color, 0.7); |
There was a problem hiding this comment.
Name of variable bg_color should be written in all lowercase letters with hyphens instead of underscores
| @@ -246,10 +246,10 @@ XfdesktopIconView.view { | |||
| box-shadow: none; | |||
|
|
|||
| &:active, &:checked, &:active:hover, &:checked:hover { | |||
| background: transparentize($bg_color, 0.7); | |||
| background: mix(black, $selected_bg_color, 40%); | |||
There was a problem hiding this comment.
Color black should be written in hexadecimal form as #000000
Color literals like black should only be used in variable declarations; they should be referred to via variable everywhere else.
Name of variable selected_bg_color should be written in all lowercase letters with hyphens instead of underscores
| } | ||
| &:hover { | ||
| background: mix(black, $selected_bg_color, 40%); | ||
| background: transparentize($bg_color, 0.7); |
There was a problem hiding this comment.
Name of variable bg_color should be written in all lowercase letters with hyphens instead of underscores
| @@ -251,10 +251,10 @@ XfdesktopIconView.view { | |||
| box-shadow: none; | |||
|
|
|||
| &:active, &:checked, &:active:hover, &:checked:hover { | |||
| background: transparentize($bg_color, 0.7); | |||
| background: mix(black, $selected_bg_color, 40%); | |||
There was a problem hiding this comment.
Color black should be written in hexadecimal form as #000000
Color literals like black should only be used in variable declarations; they should be referred to via variable everywhere else.
Name of variable selected_bg_color should be written in all lowercase letters with hyphens instead of underscores
|
Hm, I'm not sure about flipping the two. Maybe if we don't transparentize the bg_color but instead use shade to brighten it the contrast would improve too? (Currently the background of the tabwin "shines through" the currently highlighted item, making it less legible on bright backgrounds) |
|
I don't have any strong opinion on the style, as long as the hovered line doesn't "shine more" than the selected one I'm fine (this is already the case for Adwaita). Maybe screenshots can help with my point. Before this PR After this PR Adwaita |
|
@ochosi any thoughts on this? |
Don't let the mouse hover outshine the currently selected window. Supersedes #272
Don't let the mouse hover outshine the currently selected window. Supersedes #272
Don't let the mouse hover outshine the currently selected window. Supersedes #272
|
Superseded by 8fccf60 |
No description provided.