Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(updater): increase test coverage #179

Merged
merged 8 commits into from
Sep 1, 2023
Merged

Conversation

shini4i
Copy link
Owner

@shini4i shini4i commented Aug 31, 2023

Initial work towards goal stated in #178

@shini4i shini4i changed the title chore: increate test coverage chore: increase test coverage Aug 31, 2023
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #179 (525fc5e) into main (72da12c) will increase coverage by 3.55%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##             main     #179      +/-   ##
==========================================
+ Coverage   42.46%   46.01%   +3.55%     
==========================================
  Files          16       16              
  Lines        1227     1230       +3     
==========================================
+ Hits          521      566      +45     
+ Misses        647      602      -45     
- Partials       59       62       +3     
Files Changed Coverage Δ
internal/models/argo.go 59.31% <0.00%> (-0.83%) ⬇️
pkg/updater/updater.go 47.36% <100.00%> (+33.73%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Sep 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@shini4i shini4i changed the title chore: increase test coverage chore(updater): increase test coverage Sep 1, 2023
@shini4i shini4i marked this pull request as ready for review September 1, 2023 14:36
@shini4i shini4i merged commit 3785f83 into main Sep 1, 2023
6 checks passed
@shini4i shini4i deleted the chore/increase-test-coverage branch September 1, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant