New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: managed images annotation whitespace handling (#186) #188

Merged

shini4i merged 1 commit into main from fix/annotation-whitespace-handling

Sep 15, 2023

Collaborator

tomsozolins commented Sep 15, 2023 •

edited

Loading

Closes #186

codecov bot commented Sep 15, 2023 •

edited

Loading

Codecov Report

Merging #188 (4ed15fc) into main (1ec21d1) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #188   +/-   ##
=======================================
  Coverage   45.28%   45.28%           
=======================================
  Files          16       16           
  Lines        1208     1208           
=======================================
  Hits          547      547           
  Misses        597      597           
  Partials       64       64

Files Changed	Coverage Δ
internal/models/argo.go	`59.31% <100.00%> (ø)`

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more


          fix: managed images annotation whitespace handling (#186)

4ed15fc

tomsozolins force-pushed the fix/annotation-whitespace-handling branch from 779428c to 4ed15fc Compare

September 15, 2023 10:43

sonarcloud bot commented Sep 15, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

shini4i approved these changes

View reviewed changes

Owner

shini4i left a comment

Looks good, thanks!

shini4i merged commit 8e132d5 into main

6 checks passed

shini4i deleted the fix/annotation-whitespace-handling branch

September 15, 2023 10:49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet