-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
force DagModel to use joined eager load #11
Conversation
WalkthroughWalkthrough这次修改主要集中在 Changes
TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- airflow/models/dag.py (3 hunks)
Additional comments not posted (5)
airflow/models/dag.py (5)
3036-3036
: 检查DagTag
类的tags
关系定义是否正确。
3039-3039
: 检查DagOwnerAttributes
类的dag_owner_links
关系定义是否正确。
3064-3064
: 检查DagModel
类中的parent_dag
关系定义是否正确。
3069-3069
: 检查DagModel
类中的schedule_dataset_references
关系定义是否正确。
3075-3075
: 检查DagModel
类中的task_outlet_dataset_references
关系定义是否正确。
根因不是来自session,而是dagcode被意外删除了。 踩坑记录
|
背景
#6 修复了部分dagmodel的懒加载问题,但是webserver侧flask加载dagmodel又出现了问题
方案
将所有DadModel类中的懒加载全部关闭,采用joined eager loading
Summary by CodeRabbit