Bump i18n dependency #280
Merged
Bump i18n dependency #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@omitter so it does seem there is a small regression with I18n 1.1, two specs related to fallbacks are failing. I'll have to look into it, but if you want to have a look that would help speed things up. |
|
I guess it's probably ruby-i18n/i18n#415 |
|
Checking the linked commit, it looks like they simply deleted the fall back tests (here). But I guess it's not a good idea to do this here too. |
shioyama
force-pushed
the
bump_i18n_dependency
branch
from
f44caf5
to
f5b1994
Compare
shioyama
force-pushed
the
bump_i18n_dependency
branch
from
f5b1994
to
3bc22dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #278