Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: Ability to use Document Template Key when invoking query/command #23

Merged
merged 1 commit into from
Aug 19, 2023

Conversation

sethsandaru
Copy link
Member

Before: we can only use the document template UUID in order to view/update/delete/render.

After: we can use key too, so it is matching with the initial documentation https://docking.shipsaas.tech/usage/maintain-ids-keys-from-services

@sethsandaru sethsandaru self-assigned this Aug 19, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% 🎉

Comparison is base (a13c3a2) 97.55% compared to head (f12239c) 97.57%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #23      +/-   ##
============================================
+ Coverage     97.55%   97.57%   +0.01%     
- Complexity      130      131       +1     
============================================
  Files            44       44              
  Lines           614      618       +4     
============================================
+ Hits            599      603       +4     
  Misses           15       15              
Files Changed Coverage Δ
app/Models/DocumentTemplate.php 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sethsandaru sethsandaru merged commit 50c3a96 into main Aug 19, 2023
3 checks passed
@sethsandaru sethsandaru deleted the use-key-too branch August 19, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants