Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SHIP-0026 Shipwright-managed push #1046

Merged
merged 6 commits into from
Apr 18, 2023
Merged

SHIP-0026 Shipwright-managed push #1046

merged 6 commits into from
Apr 18, 2023

Conversation

SaschaSchwarze0
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 commented Apr 24, 2022 •
edited
Loading

Changes

This pull request implements the shipwright-managed push ship.

Fixes #1041

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

Release Notes

Shipwright is now capable of pushing the image built by the strategy steps to the container registry

@SaschaSchwarze0 SaschaSchwarze0 added kind/feature Categorizes issue or PR as related to a new feature. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Apr 24, 2022
@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Label for when a PR has specified a release note labels Apr 24, 2022
@openshift-ci openshift-ci bot requested review from qu1queee and sbose78 April 24, 2022 20:52
@SaschaSchwarze0 SaschaSchwarze0 force-pushed the sascha-shipwright-managed-push branch 4 times, most recently from 0ebbcd9 to 57db7ce Compare April 25, 2022 19:18
@SaschaSchwarze0 SaschaSchwarze0 force-pushed the sascha-shipwright-managed-push branch 7 times, most recently from 7dc2517 to f09f968 Compare May 8, 2022 20:50
@SaschaSchwarze0 SaschaSchwarze0 force-pushed the sascha-shipwright-managed-push branch 4 times, most recently from 499dbaf to 3d53dc8 Compare May 13, 2022 21:01
@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.10.0 milestone May 18, 2022
@SaschaSchwarze0 SaschaSchwarze0 force-pushed the sascha-shipwright-managed-push branch 2 times, most recently from 62fd9f5 to d0c02e8 Compare May 19, 2022 15:49
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 31, 2022
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 2, 2022
HeavyWombat
HeavyWombat reviewed Apr 6, 2023
View reviewed changes
Copy link
Contributor

@HeavyWombat HeavyWombat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not fully done with the review, but found some pieces where comments would be nice.

pkg/image/mutate_test.go Outdated Show resolved Hide resolved
...m-image-in-oci/blobs/sha256/014fae513d1b03a05ffe75de2db80b0d5c98fd4c8c215583560ba191523e74c0 Show resolved Hide resolved
qu1queee
qu1queee requested changes Apr 8, 2023
View reviewed changes
Copy link
Contributor

@qu1queee qu1queee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty amazing! Great work.

I'm looking forward for users using this simplified approach and enabling us to move the other security features on-top.

I left you a couple of comments. Please take a look.

pkg/reconciler/buildrun/resources/taskrun.go Outdated Show resolved Hide resolved
pkg/reconciler/buildrun/resources/taskrun.go Show resolved Hide resolved
pkg/reconciler/buildrun/resources/image_processing.go Show resolved Hide resolved
pkg/reconciler/buildrun/resources/image_processing.go Show resolved Hide resolved
pkg/reconciler/buildrun/resources/image_processing.go Outdated Show resolved Hide resolved
pkg/reconciler/buildrun/resources/image_processing.go Show resolved Hide resolved
pkg/reconciler/buildrun/resources/image_processing_test.go Show resolved Hide resolved
pkg/image/load_test.go Outdated Show resolved Hide resolved
samples/build/build_buildkit_cr.yaml Show resolved Hide resolved
docs/buildstrategies.md Show resolved Hide resolved
@SaschaSchwarze0 SaschaSchwarze0 force-pushed the sascha-shipwright-managed-push branch 4 times, most recently from 897dc64 to 4da955d Compare April 10, 2023 20:27
@SaschaSchwarze0 SaschaSchwarze0 force-pushed the sascha-shipwright-managed-push branch 4 times, most recently from df497b3 to 1e2da44 Compare April 13, 2023 18:43
qu1queee
qu1queee approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@qu1queee qu1queee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qu1queee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 18, 2023
HeavyWombat
HeavyWombat approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@HeavyWombat HeavyWombat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 18, 2023
@openshift-merge-robot openshift-merge-robot merged commit 815218b into shipwright-io:main Apr 18, 2023
@SaschaSchwarze0 SaschaSchwarze0 deleted the sascha-shipwright-managed-push branch May 11, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolfedh rolfedh rolfedh approved these changes

@qu1queee qu1queee qu1queee approved these changes

@HeavyWombat HeavyWombat HeavyWombat approved these changes

@sbose78 sbose78 Awaiting requested review from sbose78

@otaviof otaviof Awaiting requested review from otaviof

Assignees

@HeavyWombat HeavyWombat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Label for when a PR has specified a release note
Projects
None yet
Milestone
release-v0.12.0
Development

Successfully merging this pull request may close these issues.

Implement Shipwright Managed Push
5 participants
@SaschaSchwarze0 @rolfedh @HeavyWombat @qu1queee @openshift-merge-robot