Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable disabled emerging threats rules if VRT rules policy is changed #257

Open
stan-prescott opened this issue Apr 5, 2017 · 12 comments
Milestone

Comments

@stan-prescott
Copy link

The current method of disabling all emerging threats alerts in the ET rules files doesn't allow the rules to be re-enabled if the user decides they do not want to use the previously selected rules policy. It would be very useful and make it much more convenient for those that use both VRT rules and ET rules to be able to preserve any tuning they have done of ET rules if they decide to go with a VRT policy after establishing their ET rules. Since ET rules do not participate in the VRT rules policy, at the very least I would suggest disabling the ET rules by disabling (commenting out) the includes in the snort.conf file so as not to alter any edits a user has made to their ET rules or perhaps even just not change the ET rules at all and allow the user to make any changes to the ET rules as they see fit.

@stan-prescott
Copy link
Author

I asked our lead developer (Neal Murphy) for our firewall distro (Smoothwall Express 3.1) to try modifying the pulledpork.pl script to add the ability for users to switch between different VRT policies (connectivity, balanced and security) or back to a "nopolicy" state and to re-enable the ET rules when switching back to a "nopolicy" state.

I have a working pulledpork.pl script available for anyone to try out if they are interested. I would be happy to make it available in whatever way is appropriate. I don't want to step on any toes by doing this.

@shirkdog
Copy link
Owner

Work it up as a pull request and send it over, I will take a look and merge it in. Going forward, the current "release" will be stable, but anything like this will be reviewed and brought in for others to test.

@stan-prescott
Copy link
Author

stan-prescott commented Apr 11, 2017 via email

@stan-prescott
Copy link
Author

@shirkdog
I sent an email to your daemon-security address with a patch attached for the changes. If you need a pull request instead, let me know and we can try to set up a SourceForge repo to pull from.

@shirkdog
Copy link
Owner

I received it, and will take a look and review.

@stan-prescott
Copy link
Author

stan-prescott commented Apr 16, 2017 via email

@stan-prescott
Copy link
Author

Upon further testing, the original changes I provided for the re-enabling of the ET rules when changing back to a "No policy" state for the VRT and VRT Community rules and allowing switching between the different security policy states does work correctly and does not cause issues with downloading the VRT rule sets. The issues with downloading of the VRT rule sets seems to be related to other changes that were made to the pulledpork.pl script that we made for our snort installation.

The patch I provided for evaluating these changes does seem to work correctly, if you are still interested in evaluating those changes.

@stan-prescott
Copy link
Author

stan-prescott commented May 17, 2017 via email

@vrtadmin
Copy link
Contributor

There are no Talos rules for Suricata.

@stan-prescott
Copy link
Author

stan-prescott commented May 18, 2017 via email

@vrtadmin
Copy link
Contributor

vrtadmin commented May 18, 2017 via email

@shirkdog shirkdog added this to the 0.8.0 milestone Dec 6, 2017
@shirkdog
Copy link
Owner

shirkdog commented Dec 6, 2017

I have this patch and will have to take a look at this in the next release.
policy-enable-disable.patch.gz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants