Add support for OpenBSD/amd64 #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! I will create OpenBSD environment and check this great PR. Please be patient for a few days. |
|
Could you add build tag |
shirou
requested changes
Nov 24, 2016
| "unsafe" | ||
|
|
||
| "github.com/shirou/gopsutil/internal/common" | ||
| ) |
There was a problem hiding this comment.
Could you add process like freebsd?
| ret.VirtualizationSystem = system | ||
| ret.VirtualizationRole = role | ||
| } | ||
|
|
There was a problem hiding this comment.
Could you add procs like freebsd?
|
Thank you for your very cool contribution. It works on my OpenBSD 6.0 environment. I write some comments, and if you fix these, I will merge very soon!. |
This code is based on the FreeBSD version and implements roughly the same feature set.
|
Oh, I actually had done these changes, but I pushed from the wrong repository. |
shirou
approved these changes
Nov 24, 2016
|
Thank you so much !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code is based on the FreeBSD version
and implements roughly the same feature set.