Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add concrete exceptions to the adapter #5

Merged

Conversation

andersmateusz
Copy link
Contributor

No description provided.

@36864
Copy link
Collaborator

36864 commented Dec 12, 2023

Thanks. I've been meaning to do this for a while now.

I will review and merge over the weekend.

@andersmateusz
Copy link
Contributor Author

Great! Thank you for letting me know. I was doing this in hurry so I will also review this code before the weekend. One bug I've also noticed while using this adapter in my project is that fstat method while writting stream might return false, so I would handle this properly as well. I got false when reading stream from other filesystem (Azure Storage) using appropiate adapter. It seems that I have to write the stream to a new resource before writting this to Drive. I've also added some minor changes regarding code style (i.e. type annotations, typing). You are allowed to edit this code so feel free to adjust this code as u prefer.

Copy link
Collaborator

@36864 36864 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@36864 36864 merged commit 9b5e10a into shitware-ltd:master Dec 18, 2023
@36864
Copy link
Collaborator

36864 commented Dec 18, 2023

Sorry for the delay, weekend got away from me.
As for the fstat bug, I don't currently have any use cases for it so I haven't run into it. Will investigate when I have time, which at this pace is going to be next year.

@andersmateusz
Copy link
Contributor Author

fstat bug might be related to type of resource that is generated by the other adapter. I've added exception if false is returned bt fstat in this merge request so I think this is enough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants