Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add k8s version input #6

Merged
merged 2 commits into from
Aug 28, 2022
Merged

Conversation

syossan27
Copy link
Contributor

Hi, @shivjm

I'm using the helm-kubeconform-action you created in my project, and I wanted to use -kubernetes-version , so I added it to the input.
I would be happy to merge it if you want.

Thanks for making a nice GitHub Actions!

@shivjm
Copy link
Owner

shivjm commented Aug 28, 2022

That’s a great addition. I took a bit of time to test it locally and everything looks good. One nit: could we use KUBERNETES_VERSION instead of K8S_VERSION for the environment variable?

@syossan27
Copy link
Contributor Author

Thanks for the reply!
I replaced "k8s" with "kubernetes".
510ac34

@shivjm shivjm merged commit d631ce7 into shivjm:main Aug 28, 2022
@shivjm
Copy link
Owner

shivjm commented Aug 28, 2022

Thank you for the PR and the tweak!

@shivjm
Copy link
Owner

shivjm commented Aug 28, 2022

Released in v0.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants