Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for cperl strict hashpairs #17

Closed
wants to merge 2 commits into from
Closed

Conversation

rurban
Copy link
Contributor

@rurban rurban commented Jan 9, 2018

fatal under use strict since v5.27.0c.
See perl11/cperl#281
and http://perl11.org/blog/strict-hashpairs.html

With map only a missing or a single pair is allowed to construct a hash, not
multiple pairs.

fatal under use strict since v5.27.0c.
See perl11/cperl#281
and http://perl11.org/blog/strict-hashpairs.html

With map only a missing or a single pair is allowed to construct a hash, not
multiple pairs.
@shlomif
Copy link
Owner

shlomif commented Jan 9, 2018

Please see my comment on #16 - item 2 and comply.

@rurban
Copy link
Contributor Author

rurban commented Jan 9, 2018

The missing make docs is your problem. Haven't touched that.
The MSVC breakage is even worse. All the pTHX_ aTHX_ args are missing.

@shlomif
Copy link
Owner

shlomif commented Jan 9, 2018

again, Please see my comment on #16 - item no. 2 there and comply. thanks!

@shlomif
Copy link
Owner

shlomif commented Feb 7, 2018

Closing due to lack of compliance.

@shlomif shlomif closed this Feb 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants