Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more proofs #3

Merged
merged 4 commits into from
Nov 5, 2020
Merged

Add more proofs #3

merged 4 commits into from
Nov 5, 2020

Conversation

karmanyaahm
Copy link
Contributor

To avoid having too many pull requests I'll add a few platforms in this one.

  • Gitlab
  • Hackernews
  • dev.to

shombando
shombando reviewed Nov 4, 2020
View reviewed changes
Copy link
Owner

@shombando shombando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@karmanyaahm thanks for adding these proofs. I checked https://keyoxide.org/4AF679D0ABA0ED4B07BF7B6932CA3267C8D187D7 to see if you were able to test these successfully but I don't see it. Can you please confirm these are tested and I will approve the merge. Please @ mention me. Thanks again!

@shombando shombando added the enhancement New feature or request label Nov 4, 2020
@karmanyaahm
Copy link
Contributor Author

I'm actually testing these on https://keyoxide.org/772E634E9358415B1393DD9D081D3D4FBA896372 which is a separate revoked key just for testing. I'll inform you for the merge as soon as I get dev.to done later today.

@karmanyaahm karmanyaahm marked this pull request as ready for review November 4, 2020 23:45
@karmanyaahm
Copy link
Contributor Author

@shombando I think the changes are good now.

@shombando shombando merged commit 124c2ce into shombando:main Nov 5, 2020
@shombando
Copy link
Owner

Great work @karmanyaahm, thanks for your many contributions. I'm going to some minor clean-up and mark update to version 0.3.0 thanks to your proof support expansion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shombando shombando shombando left review comments

Assignees

@karmanyaahm karmanyaahm

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karmanyaahm @shombando