Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support Flutter 3.22.1 #2157

Closed
1 task done
pawlowskim opened this issue May 27, 2024 · 4 comments · Fixed by #2163
Closed
1 task done

feat: support Flutter 3.22.1 #2157

pawlowskim opened this issue May 27, 2024 · 4 comments · Fixed by #2163
Assignees

Comments

@pawlowskim
Copy link

Description

Add support for flutter 3.22.1

Requirements

  • Bump flutter version

Additional Context

Currently there is support for 3.22.0. But this version is bugged and fails to generate translations properly: dart-lang/sdk#55758

It's getting annoyed when you rely on code generation and you need constantly manually generate the translations because of bug.

@eseidel
Copy link
Contributor

eseidel commented May 28, 2024

Yeah, we're quite a bit later than normal on this one. I expect we'll do this tomorrow. Thanks for the reminder.

@eseidel
Copy link
Contributor

eseidel commented May 28, 2024

@bryanoltman is doing the roll now, should be released in a couple hours.

@erickzanardo
Copy link
Contributor

Shorebird 1.1.7 is still pointing to Flutter 3.22.0

Shorebird 1.1.7 • [email protected]:shorebirdtech/shorebird.git
Flutter 3.22.0 • revision f97740f758b5b145d687909bd09714c80875d772
Engine • revision fb9c410814a76272bdc5a66d5c3d7843b28b5ddb

✓ Shorebird is up-to-date (1.4s)
✓ Flutter install is correct (0.6s)
✓ Has access to storage.googleapis.com (0.2s)

No issues detected!

I believe we still need to roll out the new flutter version and publish a new shorebird version

@bryanoltman
Copy link
Contributor

@erickzanardo Correct. We're currently waiting for the engine artifacts to compile. Once those are done, we need to update https://github.com/shorebirdtech/flutter to point to the new engine version, and then update the CLI to point to that updated Flutter.

@bryanoltman bryanoltman changed the title feat: flutter version feat: support Flutter 3.22.1 May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants