Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP] Fix dart run missing fast path when using Flutter #55758

Closed
sigurdm opened this issue May 17, 2024 · 2 comments
Closed

[CP] Fix dart run missing fast path when using Flutter #55758

sigurdm opened this issue May 17, 2024 · 2 comments
Assignees
@vsmenon @itsjustkevin @mit-mit @athomas
Labels
area-dart-cli Use area-dart-cli for issues related to the 'dart' command like tool. cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve dart-cli-run Issues related to 'dart run'

Comments

@sigurdm
Copy link
Contributor

sigurdm commented May 17, 2024

Commit(s) to merge

dart-lang/pub@e70850b
Rolled to the sdk in: https://dart-review.googlesource.com/c/sdk/+/367024?tab=checks

Target

stable

Prepared changelist for beta/stable

https://dart-review.googlesource.com/c/sdk/+/367060

Issue Description

Without this it is hard/impossible to use build_runner together with localization on flutter.

dart run build_runner build would wrongly think that the current resolution is stale, and redo it. Missing the flutter_gen package that flutter pub get injects to the package config.

This is a regression that was introduced in: dart-lang/pub#4160 rolled to the sdk in 74c94ee

See dart-lang/build#3705

What is the fix

By fixing the fast-path check, we will not replace the package_config if it is up-to-date.

This does not fix the underlying problem that dart run doesn't inject the flutter_gen package when the resolution is stale, but at least makes it possible to run build_runner when localization is enabled.

Why cherry-pick

To fix the regression

Risk

Medium-low

Issue link(s)

See dart-lang/build#3705

Extra Info

No response
@sigurdm sigurdm added the cherry-pick-review Issue that need cherry pick triage to approve label May 17, 2024
@lrhn lrhn added area-dart-cli Use area-dart-cli for issues related to the 'dart' command like tool. dart-cli-run Issues related to 'dart run' labels May 19, 2024
@itsjustkevin
Copy link
Contributor

@jonasfj @jakemac53 could you take a look at this cherry-pick request?

@jakemac53
Copy link
Contributor

LGTM

@itsjustkevin itsjustkevin added the cherry-pick-approved Label for approved cherrypick request label May 20, 2024
copybara-service bot pushed a commit that referenced this issue May 21, 2024
@sigurdm
CP [stable] Bump pub to 9d1025414395db2dac9d590d2e567c27064783d2
4f662e8 
Changes:
```
> git log --format="%C(auto) %h %s" ed20b45..9d10254
 https://dart.googlesource.com/pub.git/+/9d102541 Fix flutter version update on fast path (4272)

```

Diff: https://dart.googlesource.com/pub.git/+/ed20b45589766d6fd135e93460b9e8255ccba519..9d1025414395db2dac9d590d2e567c27064783d2/
Change-Id: I57202cc00adc2c11cda05e9ad9c5b97af9c46deb
Cherry-pick: https://dart-review.googlesource.com/c/sdk/+/367024
Cherry-pick-request: #55758
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/367060
Reviewed-by: Jonas Jensen <[email protected]>
Commit-Queue: Sigurd Meldgaard <[email protected]>
@jakemac53 jakemac53 mentioned this issue May 22, 2024
Closed
@andrewkolos andrewkolos mentioned this issue May 24, 2024
Closed
@pawlowskim pawlowskim mentioned this issue May 27, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vsmenon vsmenon

@itsjustkevin itsjustkevin

@mit-mit mit-mit

@athomas athomas

Labels
area-dart-cli Use area-dart-cli for issues related to the 'dart' command like tool. cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve dart-cli-run Issues related to 'dart run'
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@jakemac53 @vsmenon @lrhn @sigurdm @itsjustkevin @mit-mit @athomas