Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: print message directing users to github issue if windows download takes too long #2588

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

bryanoltman
Copy link
Contributor

Description

If a user's release artifacts (libapp.so files) take longer than a minute to download, print a message directing them to #2532. This timeout can be adjusted (my experience is probably skewed due to mostly using the counter demo app for testing and having a relatively fast internet connection).

This is to help address #2532

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore
  • 🧪 Tests

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@bryanoltman bryanoltman merged commit 32d66e7 into main Oct 28, 2024
11 checks passed
@bryanoltman bryanoltman deleted the bo/patch-download-timeout-message branch October 28, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants