Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DX7 envelope misbehavior #223

Closed
dpwe opened this issue Sep 24, 2024 · 2 comments
Closed

DX7 envelope misbehavior #223

dpwe opened this issue Sep 24, 2024 · 2 comments

Comments

@dpwe
Copy link
Collaborator

dpwe commented Sep 24, 2024

eg0_type=amy.ENVELOPE_DX7 has difficulty with envelopes that exceed 1.0. So bp0='0,0,1000,2,0,0' appears to snap back to 1.0 when it hits sustain.

@dpwe
Copy link
Collaborator Author

dpwe commented Sep 24, 2024

After a quick look at the code, I think the problem is that:

I'm not sure what the right fix is here - either to allow DX7 envelopes to have targets beyond 1.0, or to modify sustain in DX7 to apply the same clipping. I would prefer to avoid the clip, but I've forgotten the details of the nonlinear MAP_ATTACK_LEVEL_S so I'm nervous to start modifying it.

@dpwe dpwe closed this as completed in 5278a7b Sep 25, 2024
dpwe added a commit that referenced this issue Sep 25, 2024
src/envelope.c: Don't clip DX7 envs at top (fixes #223).
@dpwe
Copy link
Collaborator Author

dpwe commented Sep 25, 2024

To my surprise, simply removing the MIN(12.375, ...) fixed the problem without apparently introducing any others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant