Added wave=BYO_PARTIALS for cleaner BYO_PARTIALS syntax. #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old hack of using a negative patch number with wave=PARTIALS still works, and indeed BYO_PARTIALS num_partials=... uses the same wire-code letter as patch, and the message decoder simply flips the sign of it for BYO. Thereafter PARTIALS and BYO_PARTIALS are treated the same.
TODO: Cleanup the distinction between PARTIALS and BYO_PARTIALS in the code, which is currently mediated by looking for a negative patch value in the individual PARTIAL oscs, even though they don't need or care about patch number for anything else.