Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The value "artwork" is in the wrong place #54

Closed
SomeoneElseOSM opened this issue Jun 21, 2024 · 1 comment · Fixed by #58
Closed

The value "artwork" is in the wrong place #54

SomeoneElseOSM opened this issue Jun 21, 2024 · 1 comment · Fixed by #58

Comments

@SomeoneElseOSM
Copy link

Currently https://github.com/shortbread-tiles/shortbread-docs/blob/main/shortbread-website/content/schema/1.0.md contains:

{{< tag historic artwork >}}

Based on common tagging, I'd expect this to be in "tourism" rather than "historic". See https://taginfo.openstreetmap.org/tags/historic=artwork#overview and https://taginfo.openstreetmap.org/tags/tourism=artwork#overview .

Once the schema has changed https://github.com/shortbread-tiles/shortbread-tilemaker/blob/main/process.lua#L64 will also need to change.

joto added a commit to shortbread-tiles/shortbread-tilemaker that referenced this issue Aug 27, 2024
@joto joto closed this as completed in #58 Aug 27, 2024
@joto
Copy link
Contributor

joto commented Aug 27, 2024

This has been fixed in the specs and I also fixed it in shortbread-tilemaker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants