Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escaped markdown characters seem to break parsing #214

Closed
hbCyber opened this issue Oct 29, 2015 · 3 comments
Closed

Escaped markdown characters seem to break parsing #214

hbCyber opened this issue Oct 29, 2015 · 3 comments
Assignees
Labels

Comments

@hbCyber
Copy link

hbCyber commented Oct 29, 2015

I'm using Showdown with the strikethrough option enabled.

Example input that works:
Your friend ~~[**test**](www.google.com)~~ (~~[*@test*](www.google.com)~~) updated his/her description.

Correctly results in:
<p>Your friend <del><a href="www.google.com"><strong>test</strong></a></del> (<del><a href="www.google.com"><em>@test</em></a></del>) updated his/her description.</p>

However, this input, where the username includes an asterisk, won't work:
Your friend ~~[**test\***](www.google.com)~~ (~~[*@test*](www.google.com)~~) updated his/her description.

It will result in messed up <del> tags and leaves some ~~ characters in the result:
<p>Your friend ~~<a href="www.google.com"><strong>test*</strong></a><del> (</del><a href="www.google.com"><em>@test</em></a>~~) updated his/her description.</p>

@tivie tivie added the bug label Oct 30, 2015
@tivie tivie self-assigned this Oct 30, 2015
@tivie
Copy link
Member

tivie commented Oct 30, 2015

Should be fixed in 5669317

@hbCyber
Copy link
Author

hbCyber commented Oct 30, 2015

Thanks! Well done!

@hbCyber hbCyber closed this as completed Oct 30, 2015
@tivie tivie reopened this Oct 30, 2015
@showdownjs showdownjs locked and limited conversation to collaborators Oct 30, 2015
@tivie tivie closed this as completed Jan 1, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants