Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yargs update broke the CLI #894

Closed
tivie opened this issue Mar 3, 2022 · 0 comments
Closed

Yargs update broke the CLI #894

tivie opened this issue Mar 3, 2022 · 0 comments

Comments

@tivie
Copy link
Member

tivie commented Mar 3, 2022

As reported by @gbtami in #893

After installing 2.0.1 I get this:

$ ./md2html.sh
/home/tamas/pychess-variants/node_modules/showdown/src/cli/makehtml.cmd.js:7
yargs.reset()
      ^

TypeError: yargs.reset is not a function
    at Object.<anonymous> (/home/tamas/pychess-variants/node_modules/showdown/src/cli/makehtml.cmd.js:7:7)
    at Module._compile (internal/modules/cjs/loader.js:999:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)
    at Module.load (internal/modules/cjs/loader.js:863:32)
    at Function.Module._load (internal/modules/cjs/loader.js:708:14)
    at Module.require (internal/modules/cjs/loader.js:887:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at Object.<anonymous> (/home/tamas/pychess-variants/node_modules/showdown/src/cli/cli.js:37:3)
    at Module._compile (internal/modules/cjs/loader.js:999:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)
/home/tamas/pychess-variants/node_modules/showdown/src/cli/makehtml.cmd.js:7

My script is here https://github.com/gbtami/pychess-variants/blob/master/md2html.sh

tivie added a commit that referenced this issue Mar 3, 2022
The CLI was completely rewrote. Changed dependency from yargs to commanderjs,
which is cleaner, faster and has no dependencies.
Also added a complete testsuite for the cli.

Closes #893, #894
tivie added a commit that referenced this issue Mar 3, 2022
The CLI was completely rewrote. Changed dependency from yargs to
commanderjs,
which is cleaner, faster and has no dependencies.
Also added a complete testsuite for the cli.

Merged branch 'cli_refactor' into develop

Closes #893, #894
@tivie tivie closed this as completed Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant