make Showdown compatible with Broswerify

[mattsmith14]

Browserify implements a subset of the fs module, so the current check passes, but it does not support readdirSync, so that call fails.

[Miramac]

👍

compatibility with Browserify would be awesome!

[tivie]

I will look into it as soon as possible.

[mattsmith14]

Sounds good. There are probably 4 other pull requests that attempt to fix the same/similar issues. This one is just a super simple check the fs has the method we are trying to use.

[tivie]

@varfoo yes. We are restructuring showdown. Since we'll probably move each
extension to its own repository, there will be no reason to call fs.

Regardless, the ideal way to approach the problem is abstracting the
library from the platform it's running on, in a similar fashion to
underscore.js method. This will make it compatible with node and browser
out of the box and, consequently, compatible with browserify. It will also
be easier to make the lib compatible with AMD and commonjs.

---

Estevão Soares dos Santos

---

2014-12-11 17:33 GMT+00:00 varfoo [email protected]:

Sounds good. There are probably 4 other pull requests that attempt to fix
the same/similar issues. This one is just a super simple check the fs has
the method we are trying to use.

—
Reply to this email directly or view it on GitHub
#108 (comment).

[mattsmith14]

@tivie sounds great! Thanks for stepping up and managing this, it seems like you have a lot of work on your plate.

[tivie]

#50

[tivie]

Please have a look at eae5f0e