Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimizing all files in a folder on windows? #90

Closed
dragons4life opened this issue Nov 2, 2017 · 6 comments
Closed

Optimizing all files in a folder on windows? #90

dragons4life opened this issue Nov 2, 2017 · 6 comments
Labels
I-Medium Issues that are breaking core functionality, but have a known workaround OS-Windows T-Bug Some piece of the software is not working as intended

Comments

@dragons4life
Copy link

You are able to do this on truepng by simply using *.png, however in oxipng it thinks there is a file named *.png to be opened (but you can't even have a file named *.png), this is from the command line of course.

@shssoichiro
Copy link
Owner

Thanks for reporting this! I feel like this should work on Windows without needing to do anything special, but I can verify later today once I have access to a Windows machine.

@TPS
Copy link

TPS commented Nov 3, 2017

In Windows, glob matching isn't a function of the OS (like *nixes), but of whatever matching library included in the program.

@shssoichiro
Copy link
Owner

Thanks, I didn't realize that. I usually don't develop on a Windows machine. I'll mark this as a bug to be fixed, then.

@shssoichiro shssoichiro added I-Medium Issues that are breaking core functionality, but have a known workaround T-Bug Some piece of the software is not working as intended OS-Windows labels Nov 3, 2017
@TPS
Copy link

TPS commented Nov 3, 2017

https://www.google.com/search?q=windows+rust+glob+matching finds https://doc.rust-lang.org/glob/, https://github.com/rust-lang-nursery/glob, &c, which might all be instructive.

shssoichiro pushed a commit that referenced this issue Nov 7, 2017
shssoichiro pushed a commit that referenced this issue Nov 7, 2017
@shssoichiro
Copy link
Owner

Sorry, I should have mentioned that this was fixed in 0.18.0.

@dragons4life
Copy link
Author

It's fine, thanks for adding it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I-Medium Issues that are breaking core functionality, but have a known workaround OS-Windows T-Bug Some piece of the software is not working as intended
Projects
None yet
Development

No branches or pull requests

3 participants