Switch to standard logging library #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to configure or compile away logging in the library from a single place in Rust apps. For the CLI side, the usage and output remained the same, except it's now colour-coded. Fixes shssoichiro#217.
|
(fixing tests) |
|
Fixed tests, also expanded |
To show an example - this is what I mean by colour-coded (specific colours depend on the terminal theme, of course): |
shssoichiro
requested changes
Apr 18, 2020
Co-Authored-By: Josh Holmer <[email protected]>
RReverser
commented
Apr 18, 2020
| @@ -695,7 +670,7 @@ fn optimize_png( | |||
| } | |||
| } | |||
|
|
|||
| eprintln!( | |||
| error!( | |||
There was a problem hiding this comment.
@shssoichiro By the way, I'm not sure whether it's worth keeping this log message if it's duplicate in an actual error too (and will be printed e.g. by CLI app twice). Thoughts?
There was a problem hiding this comment.
I'm not entirely sure. But theoretically this should never show up, and if it does, we'll definitely want the user to be aware of it. So I think it's fine to leave it.
shssoichiro
approved these changes
Apr 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to configure or compile away logging in the library from a single place in Rust apps.
For the CLI side, the usage and output remained the same, except it's now colour-coded.
Fixes #217.