warning: usage of a legacy numeric method --> src/lib.rs:280:42 | 280 | assert_eq!(entropy.guesses, u64::max_value()); | ^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants = note: `#[warn(clippy::legacy_numeric_constants)]` on by default help: use the associated constant instead | 280 | assert_eq!(entropy.guesses, u64::MAX); | ~~~

the borrowed expression implements the required traits: src/scoring.rs#L1169

warning: the borrowed expression implements the required traits --> src/scoring.rs:1169:42 | 1169 | let value = serde_json::to_value(&score).unwrap(); | ^^^^^^ help: change this to: `score` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default

casting to the same type is unnecessary (`u64` -> `u64`): src/scoring.rs#L969

warning: casting to the same type is unnecessary (`u64` -> `u64`) --> src/scoring.rs:969:31 | 969 | ... * (*scoring::KEYBOARD_STARTING_POSITIONS | _________________________^ 970 | | ... * scoring::KEYBOARD_AVERAGE_DEGREE.pow(j as u32)) 971 | | ... as u64 | |________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast help: try | 969 ~ * (*scoring::KEYBOARD_STARTING_POSITIONS 970 + * scoring::KEYBOARD_AVERAGE_DEGREE.pow(j as u32)) |

casting to the same type is unnecessary (`u64` -> `u64`): src/scoring.rs#L952

warning: casting to the same type is unnecessary (`u64` -> `u64`) --> src/scoring.rs:952:39 | 952 | assert_eq!(p.estimate(token), base_guesses as u64); | ^^^^^^^^^^^^^^^^^^^ help: try: `{ base_guesses }` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

casting to the same type is unnecessary (`u64` -> `u64`): src/scoring.rs#L920

warning: casting to the same type is unnecessary (`u64` -> `u64`) --> src/scoring.rs:920:39 | 920 | assert_eq!(p.estimate(token), base_guesses as u64); | ^^^^^^^^^^^^^^^^^^^ help: try: `{ base_guesses }` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast = note: `#[warn(clippy::unnecessary_cast)]` on by default

casting the result of `i32::abs()` to u64: src/scoring.rs#L892

warning: casting the result of `i32::abs()` to u64 --> src/scoring.rs:892:19 | 892 | 365 * (*scoring::REFERENCE_YEAR - p.year).abs() as u64 | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `(*scoring::REFERENCE_YEAR - p.year).unsigned_abs()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_abs_to_unsigned

casting the result of `i32::abs()` to u64: src/scoring.rs#L857

warning: casting the result of `i32::abs()` to u64 --> src/scoring.rs:857:13 | 857 | (*scoring::REFERENCE_YEAR - 1972).abs() as u64 | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `(*scoring::REFERENCE_YEAR - 1972).unsigned_abs()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_abs_to_unsigned = note: `#[warn(clippy::cast_abs_to_unsigned)]` on by default

manual `RangeInclusive::contains` implementation: src/scoring.rs#L564

warning: manual `RangeInclusive::contains` implementation --> src/scoring.rs:564:16 | 564 | if n >= 63 && n <= 100 { | ^^^^^^^^^^^^^^^^^^^ help: use: `(63..=100).contains(&n)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains = note: `#[warn(clippy::manual_range_contains)]` on by default

used `assert_eq!` with a literal bool: src/matching/mod.rs#L1211

warning: used `assert_eq!` with a literal bool --> src/matching/mod.rs:1211:9 | 1211 | assert_eq!(p.ascending, false); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison help: replace it with `assert!(..)` | 1211 - assert_eq!(p.ascending, false); 1211 + assert!(!p.ascending); |

used `assert_eq!` with a literal bool: src/matching/mod.rs#L1085

warning: used `assert_eq!` with a literal bool --> src/matching/mod.rs:1085:13 | 1085 | assert_eq!(p.l33t, true); | ^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison help: replace it with `assert!(..)` | 1085 - assert_eq!(p.l33t, true); 1085 + assert!(p.l33t); |

used `assert_eq!` with a literal bool: src/matching/mod.rs#L1066

warning: used `assert_eq!` with a literal bool --> src/matching/mod.rs:1066:13 | 1066 | assert_eq!(p.l33t, true); | ^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison help: replace it with `assert!(..)` | 1066 - assert_eq!(p.l33t, true); 1066 + assert!(p.l33t); |

used `assert_eq!` with a literal bool: src/matching/mod.rs#L993

warning: used `assert_eq!` with a literal bool --> src/matching/mod.rs:993:13 | 993 | assert_eq!(p.reversed, true); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison = note: `#[warn(clippy::bool_assert_comparison)]` on by default help: replace it with `assert!(..)` | 993 - assert_eq!(p.reversed, true); 993 + assert!(p.reversed); |

clippy-rustfmt

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

clippy-rustfmt

The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

clippy-rustfmt

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

clippy-rustfmt

build-wasm

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, jetli/[email protected]. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

build-wasm

The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v2, actions-rs/toolchain@v1, jetli/[email protected]. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

build-wasm

build (ubuntu-latest)

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

build (ubuntu-latest)

The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v2, actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

build (ubuntu-latest)

build (windows-latest)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Version 3.1.0 #80

Summary

Version 3.1.0 #80

Jobs

Run details

zxcvbn.yml

Annotations