remove n+1 query from user#tagnames method (publiclab#8190)

shubhangikori · Oct 12, 2020 · de0a69e · de0a69e
1 parent 88436ae
commit de0a69e
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/app/models/user.rb b/app/models/user.rb
@@ -157,7 +157,7 @@ def normal_tags
 
   def tagnames(limit = 20, defaults = true)
     tagnames = []
-    Node.order('nid DESC').where(type: 'note', status: 1, uid: id).limit(limit).each do |node|
+    Node.includes(:tag).order('nid DESC').where(type: 'note', status: 1, uid: id).limit(limit).each do |node|
       tagnames += node.tags.collect(&:name)
     end
     tagnames.uniq