Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rediska_Serializer_Adapter_Json::unserialize returns same value that was passed in #75

Open
trickeyone opened this issue Oct 10, 2012 · 1 comment
Labels

Comments

@trickeyone
Copy link
Contributor

The Rediska_Serializer_Adapter_Json::unserialize method is returning the same value that is being passed in to be unserialized. Please see below:

Lines 88-97

    public function unserialize($value)
    {
        $decodedValue = json_decode($value);

        if ($decodedValue === null && $value !== 'null') {
            throw new Rediska_Serializer_Adapter_Exception("Can't unserialize value");
        }

        return $value;
    }

The last line should, instead be "return $decodedValue;".

    public function unserialize($value)
    {
        $decodedValue = json_decode($value);

        if ($decodedValue === null && $value !== 'null') {
            throw new Rediska_Serializer_Adapter_Exception("Can't unserialize value");
        }

        return $decodedValue;
    }
shumkov added a commit that referenced this issue Aug 7, 2013
Fixing issue with Rediska_Serializer_Adapter_Json::unserialize method not return unserialized value, Issue #75
@iwsfg
Copy link

iwsfg commented May 8, 2015

Btw, they fixed it in 16f1224, but this issue remained open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants