logger: store span names #1166
Merged
logger: store span names #1166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chesedo
reviewed
Aug 21, 2023
oddgrd
reviewed
Aug 21, 2023
iulianbarbu
force-pushed
the
feature/eng-1024-consider-storing-span-names
branch
2 times, most recently
from
2d738f1
to
5af99a9
Compare
orhun
approved these changes
Aug 22, 2023
iulianbarbu
force-pushed
the
feature/eng-1024-consider-storing-span-names
branch
from
5af99a9
to
b8796f9
Compare
iulianbarbu
merged commit f04245f
into
shuttle-hq:feat/shuttle-logger-service
30 of 33 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Previously we dropped on any span name information, but we'll need them to be shown in
cargo-shuttle.How has this been tested? (if applicable)
Through integration tests. Need to follow up with more local/unstable testing soon.