feat: display the source of client error #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrytothemoon
changed the title
harrytothemoon
changed the title
harrytothemoon
changed the title
harrytothemoon
force-pushed
the
fix/client-error
branch
from
7b37db1
to
2dc242a
Compare
liximomo
requested changes
Aug 19, 2022
liximomo
requested changes
Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note:
While using lib
source-map v0.7.4, some unanticipated errors (client-side issues) occurred in client side, so I try to add webpack compilation options in browser (fallback: fs:false) by referring to libreact-error-overlay, and still had other issues after successful compilation (same issue).Referring to comments in issue and next.js dependency, I upgraded it to
v0.8.0-beta.0and other errors (same issue) were occurred.Refer to lib
react-error-overlaydependency version and downgraded it tov0.5.7which successfully solved the aforementioned issues from client.What kind of change does this PR introduce?
Did you add tests(unit,e2e) for your changes?
Does this PR introduce a breaking change?
What needs to be documented once your changes are merged?