Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration of prettier into the code #258

Merged
merged 7 commits into from
Jun 12, 2023
Merged

Conversation

Sage-2001
Copy link
Contributor

Description

  • Install Prettier as a dev dependency using npm.
  • Configure Prettier with our preferred code formatting rules.
  • Add a pre-commit hook or integrate Prettier into our build process to automatically format code.

Related Issues

[Feat]: Add Prettier for Code Formatting #248

Changes Proposed

Formatted according to prettier and prettier integrated into the code. Can be used using npm run build

Checklist

  • I have read and followed the Contribution Guidelines.
  • All new and existing tests passed.
  • I have updated the documentation to reflect the changes I've made.
  • My code follows the code style of this project.
  • The title of my pull request is a short description of the requested changes.

@vercel
Copy link

vercel bot commented Jun 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dev-find ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2023 0:36am

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @Sage-2001! 🎉 Thank you for opening a pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

Soon the maintainers/owner will review it and provide you with feedback/suggestions.

@shyamtawli
Copy link
Owner

Hey @Sage-2001 Nice work but we are using pnpm for that reason deployment is not running and showing errors. Fix it and ping me.

@Sage-2001
Copy link
Contributor Author

Hey @Sage-2001 Nice work but we are using pnpm for that reason deployment is not running and showing errors. Fix it and ping me.

@shyamtawli can you tell me exactly what needs to be done i am a little confused

@shyamtawli
Copy link
Owner

@Sage-2001 We are facing deployment errors. I will look into it and let you know, In the meantime you can also have look into it by going through checks section above.

@Sage-2001
Copy link
Contributor Author

@Sage-2001 We are facing deployment errors. I will look into it and let you know, In the meantime you can also have look into it by going through checks section above.

Ok

@Sage-2001
Copy link
Contributor Author

@shyamtawli any updates >?

@shyamtawli
Copy link
Owner

@Sage-2001 Was busy on other works. Soon I will let you know.

@Sage-2001
Copy link
Contributor Author

@Sage-2001 Was busy on other works. Soon I will let you know.

any updates ?

@shyamtawli
Copy link
Owner

Hey @Sage-2001 Can you share what specific and files you changes because I have tried adding prettier myself and the deployment is running fine. Other than adding .prettier file what changes you have made.

My PR for prettier #267

@Sage-2001
Copy link
Contributor Author

Hey @Sage-2001 Can you share what specific and files you changes because I have tried adding prettier myself and the deployment is running fine. Other than adding .prettier file what changes you have made.

My PR for prettier #267

@shyamtawli
The main changes were made to
.prettierrc.json
package.json

@shyamtawli
Copy link
Owner

See the PR I have opened and make changes. Don't add husky now we will add it later.
Only add prettier and add the script on package.json file. Refer my PR.

@Sage-2001
Copy link
Contributor Author

See the PR I have opened and make changes. Don't add husky now we will add it later. Only add prettier and add the script on package.json file. Refer my PR.

Hey, I changed the .prettier file and script on the package.json according to your PR #267

@shyamtawli
Copy link
Owner

@Sage-2001 Nice. Now the deployment is also working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants