-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(components/Profile): Fixed skill scroll problem (fixes #282) #297
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, @HanzCEO! 🎉 Thank you for opening a pull request. Your contribution is valuable and we appreciate your efforts to improve our project.
Soon the maintainers/owner will review it and provide you with feedback/suggestions.
Hey @HanzCEO its not working. When I am trying to scroll whole page is scrolling. |
@shyamtawli, I use my touchpad and scroll to left/right and it works. I will make another commit addressing this shortly. |
@shyamtawli It should be working as of now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HanzCEO Nice Work but we have to add a scroll-bar when a user hovers on skills-section.
Added scrollbar back |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, I have a question why did you removed scroll-bar, any specific reason?
@HanzCEO Thank you so much for your contribution! Your efforts are greatly appreciated and will go a long way in improving our project. Please feel free to share it with others and Star the repo to help us grow even further! |
I feel like it doesn't belong there. Although readding them reminds me of accessibility. Maybe someday we should listen to touch events in addition to wheel events that is implemented today. |
Description
This fixes #282 by disabling scroll CSS
Related Issues
#282
Changes Proposed
master...HanzCEO:devFind-fix-282:master#diff-87874f2a1717746197c063e0fb66f23bd367dc113af1abc23cf9db0ed9374dd5R20-R22
I added an algorithm to find
skills-container
parent so wherever the onWheel event takes place, it will changeskilss-container.leftScroll
property instead of its child.Checklist