Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components/Profile): Fixed skill scroll problem (fixes #282) #297

Merged
merged 5 commits into from
Jul 3, 2023
Merged

Conversation

HanzCEO
Copy link
Contributor

@HanzCEO HanzCEO commented Jun 30, 2023

Description

This fixes #282 by disabling scroll CSS

Related Issues

#282

Changes Proposed

master...HanzCEO:devFind-fix-282:master#diff-87874f2a1717746197c063e0fb66f23bd367dc113af1abc23cf9db0ed9374dd5R20-R22
I added an algorithm to find skills-container parent so wherever the onWheel event takes place, it will change skilss-container.leftScroll property instead of its child.

Checklist

  • I have read and followed the Contribution Guidelines.
  • All new and existing tests passed.
  • I have updated the documentation to reflect the changes I've made.
  • My code follows the code style of this project.
  • The title of my pull request is a short description of the requested changes.

@vercel
Copy link

vercel bot commented Jun 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dev-find ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2023 0:39am

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @HanzCEO! 🎉 Thank you for opening a pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

Soon the maintainers/owner will review it and provide you with feedback/suggestions.

@shyamtawli
Copy link
Owner

Hey @HanzCEO its not working. When I am trying to scroll whole page is scrolling.

@HanzCEO
Copy link
Contributor Author

HanzCEO commented Jul 2, 2023

@shyamtawli, I use my touchpad and scroll to left/right and it works.
However, to support up/down scroll i have to do another work.

I will make another commit addressing this shortly.

@HanzCEO
Copy link
Contributor Author

HanzCEO commented Jul 2, 2023

@shyamtawli It should be working as of now.

Copy link
Owner

@shyamtawli shyamtawli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HanzCEO Nice Work but we have to add a scroll-bar when a user hovers on skills-section.

@shyamtawli shyamtawli added the enhancement New feature or request label Jul 2, 2023
@HanzCEO
Copy link
Contributor Author

HanzCEO commented Jul 2, 2023

Added scrollbar back

@HanzCEO HanzCEO requested a review from shyamtawli July 2, 2023 13:22
Copy link
Owner

@shyamtawli shyamtawli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, I have a question why did you removed scroll-bar, any specific reason?

@shyamtawli
Copy link
Owner

@HanzCEO Thank you so much for your contribution! Your efforts are greatly appreciated and will go a long way in improving our project. Please feel free to share it with others and Star the repo to help us grow even further!

@HanzCEO
Copy link
Contributor Author

HanzCEO commented Jul 3, 2023

Approved, I have a question why did you removed scroll-bar, any specific reason?
@shyamtawli

I feel like it doesn't belong there. Although readding them reminds me of accessibility. Maybe someday we should listen to touch events in addition to wheel events that is implemented today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: skills scrollbar not working
2 participants