Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PERF]: Optimized Search Input box and added a delete button to clear the input box. #459

Merged
merged 5 commits into from
Oct 6, 2023

Conversation

Bismay5467
Copy link
Contributor

Description

  • added a customised debounce hook to optimise search input box performance.
  • added functionality to auto focus on search box on pressing Ctrl + K (for windows) and Cmd (⌘) + K (for macOS).
  • added a delete button to clear the search input box.

Fixes #457

Checklist

  • I have read and followed the Contribution Guidelines.
  • All new and existing tests passed.
  • I have updated the documentation to reflect the changes I've made.
  • My code follows the code style of this project.
  • The title of my pull request is a short description of the requested changes.

Screenshots

image

Note to reviewers

@shyamtawli can you please review this PR? Any feedback will be highly appreciated!!

@vercel
Copy link

vercel bot commented Oct 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dev-find ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 6, 2023 11:35am

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @Bismay5467! 🎉 Thank you for opening a pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

Soon the maintainers/owner will review it and provide you with feedback/suggestions.

@Bismay5467
Copy link
Contributor Author

@shyamtawli I am not sure which part of the documentation needs an update to match the changes that this PR will create.
Can you please guide me?

@shyamtawli
Copy link
Owner

You don't need to update any documentation.

I like the changes, but we can remove functionality to focus on pressing keywords because we are already focusing on search bar when user enters.

@shyamtawli shyamtawli added the enhancement New feature or request label Oct 6, 2023
@Bismay5467
Copy link
Contributor Author

Bismay5467 commented Oct 6, 2023

@shyamtawli I've committed all the changes you asked for. Can you please have a look at it?

@shyamtawli shyamtawli changed the title perf: optimised search input box and added a delete button to clear the input box. [PERF]: Optimized Search Input box and added a delete button to clear the input box. Oct 6, 2023
@shyamtawli shyamtawli merged commit eb6e4f8 into shyamtawli:master Oct 6, 2023
3 checks passed
@shyamtawli
Copy link
Owner

@Bismay5467 Thank you so much for your contribution! Your efforts are greatly appreciated and will go a long way in improving our project. Please feel free to share it with others and Star the repo to help us grow even further!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENHANCEMENT] : optimising the performance of search input box.
2 participants