-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PERF]: Optimized Search Input box and added a delete button to clear the input box. #459
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, @Bismay5467! 🎉 Thank you for opening a pull request. Your contribution is valuable and we appreciate your efforts to improve our project.
Soon the maintainers/owner will review it and provide you with feedback/suggestions.
@shyamtawli I am not sure which part of the documentation needs an update to match the changes that this PR will create. |
You don't need to update any documentation. I like the changes, but we can remove functionality to focus on pressing keywords because we are already focusing on search bar when user enters. |
@shyamtawli I've committed all the changes you asked for. Can you please have a look at it? |
5204b9c
to
a8e0346
Compare
@Bismay5467 Thank you so much for your contribution! Your efforts are greatly appreciated and will go a long way in improving our project. Please feel free to share it with others and Star the repo to help us grow even further! |
Description
Fixes #457
Checklist
Screenshots
Note to reviewers
@shyamtawli can you please review this PR? Any feedback will be highly appreciated!!