Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[STYLE]: Center the 'No Result Found' text on search. #528

Merged
merged 1 commit into from
Oct 15, 2023
Merged

[STYLE]: Center the 'No Result Found' text on search. #528

merged 1 commit into from
Oct 15, 2023

Conversation

mrswastik-robot
Copy link
Contributor

Description

Earlier when searching , when search didn't find any result , the text ' No Results Found ' was displayed on the screen but it was aligned to the left of the screen which didn't look professional. I have aligned it to the center which looks better.

Related Issues

Fixes #505

Changes Proposed

I have aligned the text to the center using css.
Change is made in ' NoResultFound.css ' file and the code added is :
text-align: center;

Checklist

  • I have read and followed the Contribution Guidelines.
  • All new and existing tests passed.
  • I have updated the documentation to reflect the changes I've made.
  • My code follows the code style of this project.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Before

image

After

image

Note to reviewers

Do let me know if any further changes or improvements are required before merging.

@vercel
Copy link

vercel bot commented Oct 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dev-find ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 12, 2023 2:32pm

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @mrswastik-robot! 🎉 Thank you for opening a pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

Soon the maintainers/owner will review it and provide you with feedback/suggestions.

@shyamtawli shyamtawli changed the title Center the 'No Result Found' text on search. [STYLE]: Center the 'No Result Found' text on search. Oct 15, 2023
@shyamtawli shyamtawli added the enhancement New feature or request label Oct 15, 2023
@shyamtawli shyamtawli merged commit ed693cf into shyamtawli:master Oct 15, 2023
4 checks passed
@shyamtawli
Copy link
Owner

@mrswastik-robot Thanks again for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat]: Centering the ' No Result Found ' on search.
2 participants