Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added favicon and meta description #65 #66

Merged
merged 7 commits into from
Apr 30, 2023

Conversation

dcryptoniun
Copy link
Contributor

first of all sorry created pr without the issue assigned to me

Changed meta description

from : "Website created using create-react-app"

to : "Devfind is an open-source website that provides a platform for developers to showcase their profiles. With Devfind, users can easily search and find developers based on their specific needs. Whether you're looking for a web developer or a mobile app developer, Devfind has got you covered. Sign up today and discover the perfect developer for your project!"

added favicon: </>
android-chrome-192x192

let me know if any changes needed

@vercel
Copy link

vercel bot commented Apr 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dev-find ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2023 8:54am

@vercel vercel bot temporarily deployed to Preview April 29, 2023 05:22 Inactive
@shyamtawli
Copy link
Owner

@dcryptoniun I think matching the favicon background color with site background will look good. What do you say?

@vercel vercel bot temporarily deployed to Preview April 29, 2023 12:40 Inactive
@dcryptoniun
Copy link
Contributor Author

@shyamtawli sure

favicon background change
from: blue
to : rgba(20, 29, 47, 1) {background color of website}
@vercel vercel bot temporarily deployed to Preview April 29, 2023 13:07 Inactive
@vercel vercel bot temporarily deployed to Preview April 29, 2023 17:50 Inactive
@dcryptoniun
Copy link
Contributor Author

@shyamtawli background color of the favicon changed.
any changes you want in the meta description?

public/index.html Outdated Show resolved Hide resolved
updated meta description with the suggestion

Co-authored-by: Shyam Tawli <[email protected]>
@vercel vercel bot temporarily deployed to Preview April 30, 2023 08:53 Inactive
@vercel vercel bot temporarily deployed to Preview April 30, 2023 08:54 Inactive
@shyamtawli shyamtawli merged commit 111431a into shyamtawli:master Apr 30, 2023
@shyamtawli
Copy link
Owner

@dcryptoniun Thanks for the Contribution.

@dcryptoniun dcryptoniun deleted the description-and-favicon branch April 30, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants