Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(alias): support alias for other version than default #388

Open
davinkevin opened this issue Jan 21, 2019 · 16 comments
Open

feat(alias): support alias for other version than default #388

davinkevin opened this issue Jan 21, 2019 · 16 comments
Milestone

Comments

@davinkevin
Copy link

Hi,

I maybe miss something, but I use jabba every day, and switching between v8 and v11 of java with Jabba requires to use the default name of each version (unless you defined one as the default).

It would be great to be able to do something like this jabba alias 11 [email protected] and then jabba use 11.

@mikethebos
Copy link
Contributor

@shyiko @davinkevin Here we go: #557

@mikethebos
Copy link
Contributor

@davinkevin Hey. Can you let us know if my pull request works for you?

@davinkevin
Copy link
Author

Is there a release made with your PR?

@mikethebos
Copy link
Contributor

@davinkevin No, but here is a copy of the binary to replace in .jabba/bin: https://www.dropbox.com/s/bh9b89s5spzor90/jabba?dl=0

@mikethebos
Copy link
Contributor

@davinkevin That is a linux amd64 binary by the way.

@davinkevin
Copy link
Author

davinkevin commented Nov 8, 2019

I'm not a huge fan of running a binary distributed like this, for security reason.

So, to test it, I will have to build a VM and import it...

@mikethebos
Copy link
Contributor

@davinkevin or compile my code from my PR... I used go1.13.4.

@mikethebos
Copy link
Contributor

@davinkevin @shyiko used go1.11.4, so you may want to compile my PR with that.

@davinkevin
Copy link
Author

It's perfect for me 👍. You can merge it

@jborgers
Copy link

jborgers commented Jun 13, 2020

Would be a nice improvement!
@davinkevin @mikethebos @shyiko : How is this going?

@mikethebos
Copy link
Contributor

Works for me.

@ghost ghost mentioned this issue Nov 24, 2020
@benjamin-rood
Copy link

Should be closed?

@davinkevin
Copy link
Author

davinkevin commented Aug 19, 2021

Could be @benjamin-rood, but no release has been made since 2019, so I not able to see it in action sadly…

@benjamin-rood
Copy link

Could be @benjamin-rood, but no release has been made since 2019, so I not able to see it in action sadly…

How sad. I think we need to fork this project and take it over if it has been abandoned...

@willcohen
Copy link
Collaborator

Not abandoned, just a little undermaintained! I’ll try to find a little time tomorrow to work through some backlog. It’s definitely overdue for a release…

@willcohen willcohen added this to the 0.11.3 milestone Aug 22, 2021
@ZaLiTHkA
Copy link

@willcohen, I'm pretty sure you've already put some thought into this, but might I suggest moving the alias files into a subfolder here..?

for example, creating a new default alias should create a file at %USERPROFILE%\.jabba\alias\default, rather than %USERPROFILE%\.jabba\default.alias. using the OP example, aliasing a JDK to 8 would then create a file at %USERPROFILE%\.jabba\alias\8 (which is totally valid, even on Windows).

I don't have any experience with Go, so I can't exactly jump into the code and make this change myself.... but I suspect this might make it easier to work with these alias files deep in Jabba itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants