Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider a fork #833

Open
willcohen opened this issue Mar 12, 2022 · 12 comments
Open

Consider a fork #833

willcohen opened this issue Mar 12, 2022 · 12 comments

Comments

@willcohen
Copy link
Collaborator

Hello all,

While @shyiko gave me commit access a while back, I don't actually have admin rights to either this or the autodiscovery repos, meaning that I can't on my own fix CI, which is kind of a fundamental requirement for having jabba stay up to date with JDK releases. I'm not actually a Go programmer and have also generally moved to other JDK management tools, so I'm probably not the right person to be the overall maintainer for this tool.

I'd suggest that you all fork it to an organization to allow the project to continue (and most importantly, get CI working!)

@mkurz
Copy link

mkurz commented Apr 14, 2022

@shyiko why not give @willcohen admin permissions to this and the autodiscovery repository?

@saschpe
Copy link

saschpe commented Jun 1, 2022

Another way would be to create an Organization and move the repository there. This way, you can easily have multiple admins.

@willcohen
Copy link
Collaborator Author

@benjamin-rood @davinkevin @saschpe
re #388 and #835, given that I'm not a Go programmer, I want to just mention you all here, in case any of you are interested in forking this into a new repo for further development. From my perspective the most important part is still completing migration of autodiscovery to github CI -- without that, jabba's list of jdks is always going to remain unmaintainably out of date!

@leonard84
Copy link

If a fork into a new organizations is what is required to make jabba work again with newer Java versions, then please go ahead and do so. As naming is hard I'd suggest to follow the junit project and call the organization jabba-team.

@patrick-mccourt
Copy link

I have created an organisation and forked both jabba and auto discovery: https://github.com/Jabba-Team

I haven't done much Go before but I'll see what I can do. First thing I'm looking at is fixing autodiscovery & migrating it to Github actions per this issue: shyiko/jabba-autodiscovery#17

other volunteers welcome.

@saschpe
Copy link

saschpe commented Jul 14, 2022

If you'd want you could add me as well. I'd probably merge a couple PRs to get some missing bits

@leonard84
Copy link

@patrick-mccourt I think that switching to discoapi #778 might be better than trying to fix auto discovery

@patrick-mccourt
Copy link

Hi all, just a heads up to let you know I've been hacking away this week and have just published an alpha release of Jabba 0.12.0 over in the Jabba-Team fork: https://github.com/Jabba-Team/jabba

functionality wise it's exactly the same program, just renaming the references to point to the new org and a new, up to date JDK index using DiscoAPI as per leonard84's suggestion above. The Index file should be compatible with earlier jabba versions too though I've not confirmed this. I hope to do some more testing and will 'release' fully when I know it works. Thanks for your patience!

@hatanakadaniel
Copy link

Hi all, just a heads up to let you know I've been hacking away this week and have just published an alpha release of Jabba 0.12.0 over in the Jabba-Team fork: https://github.com/Jabba-Team/jabba

functionality wise it's exactly the same program, just renaming the references to point to the new org and a new, up to date JDK index using DiscoAPI as per leonard84's suggestion above. The Index file should be compatible with earlier jabba versions too though I've not confirmed this. I hope to do some more testing and will 'release' fully when I know it works. Thanks for your patience!

Hi @patrick-mccourt, can we consider the new repository (https://github.com/Jabba-Team/jabba) like the Jabba's official repository now?

@willcohen
Copy link
Collaborator Author

You can!

@saschpe
Copy link

saschpe commented Dec 6, 2022

Hi all, just a heads up to let you know I've been hacking away this week and have just published an alpha release of Jabba 0.12.0 over in the Jabba-Team fork: https://github.com/Jabba-Team/jabba

I wonder if there's still time to integrate a merge request before release: Jabba-Team#13 :-)

@nicerloop
Copy link

Hi @willcohen , can you update the README to officially direct users to the new fork, perhaps with a reference to this ticket?

archlinux-github pushed a commit to archlinux/aur that referenced this issue Jun 28, 2023
Development switched to a place
shyiko/jabba#833 (comment)

Adjust the package in regards of Go package guidelines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants