Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added batch wrapper to support cmd.exe, slight powershell rework #86

Merged
merged 3 commits into from
Jun 22, 2017

Conversation

rubin55
Copy link

@rubin55 rubin55 commented Jun 22, 2017

Hi Shyiko,

Here is a pull request with a batch script that makes it possible to use jabba from a regular cmd.exe.

I additionally did a small change on install.ps1 to unhinge jabba.ps1 from it, and make it a little bit more conforming to PowerShell's way of doing things. The installer now fetches the ps1 script from the matching release version. It does the same for the batch script.

Finally, I updated the install message which now mentions the batch script and a user can choose to add it to their path in one way or the other.

@shyiko
Copy link
Owner

shyiko commented Jun 22, 2017

@rubin55 Outstanding! Thank you so much for this! 🙇‍♂️

@shyiko shyiko merged commit f3b942e into shyiko:develop Jun 22, 2017
@rubin55
Copy link
Author

rubin55 commented Jun 23, 2017

Hey Shyiko, I just noticed I forgot the alias for Invoke-Jabba. The following needs to be added to jabba.ps1 so a user can type "jabba" instead of "Invoke-Jabba" :

Set-Alias jabba Invoke-Jabba

@shyiko
Copy link
Owner

shyiko commented Jun 23, 2017

@rubin55 🤝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants