Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 image factory allocates lots of RAM when processing a request for the installer image #77

Closed
Tracked by #1
smira opened this issue Dec 21, 2023 · 0 comments · Fixed by #79
Closed
Tracked by #1

🐛 image factory allocates lots of RAM when processing a request for the installer image #77

smira opened this issue Dec 21, 2023 · 0 comments · Fixed by #79
Assignees
@smira

Comments

@smira
Copy link
Member

smira commented Dec 21, 2023

image
@smira smira mentioned this issue Dec 21, 2023
Closed
@smira smira self-assigned this Dec 22, 2023
smira added a commit to smira/talos that referenced this issue Dec 22, 2023
@smira
fix: replace the filemap implementation to not buffer in memory
3c6f4e0 
This filemap is used to generate installer image layer with artifcats.

Previous dumb implementation buffered in memory which leads to extensive
memory usage.

See siderolabs/image-factory#77

Signed-off-by: Andrey Smirnov <[email protected]>
@smira smira mentioned this issue Dec 22, 2023
Merged
smira added a commit to smira/talos that referenced this issue Dec 22, 2023
@smira
fix: replace the filemap implementation to not buffer in memory
265f21b 
This filemap is used to generate installer image layer with artifacts.

Previous dumb implementation buffered in memory which leads to extensive
memory usage.

See siderolabs/image-factory#77

Signed-off-by: Andrey Smirnov <[email protected]>
@smira smira mentioned this issue Dec 22, 2023
Merged
smira added a commit to smira/talos that referenced this issue Jan 18, 2024
@smira
fix: replace the filemap implementation to not buffer in memory
b476195 
This filemap is used to generate installer image layer with artifacts.

Previous dumb implementation buffered in memory which leads to extensive
memory usage.

See siderolabs/image-factory#77

Signed-off-by: Andrey Smirnov <[email protected]>
(cherry picked from commit 265f21b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smira smira

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: memory usage when building an installer smira/image-service
1 participant
@smira