Skip to content

Commit

Permalink
fix: fix azure portion of cloud uploader
Browse files Browse the repository at this point in the history
Correctly propagate errors back. Drop ARM templates and use native APIs.
Correctly handle restarted runs for creating image versions. fixes #7512.

Signed-off-by: Christian Rolland <[email protected]>
  • Loading branch information
ro11net committed Aug 3, 2023
1 parent 793dced commit ac2aff5
Show file tree
Hide file tree
Showing 9 changed files with 122 additions and 312 deletions.
3 changes: 2 additions & 1 deletion hack/cloud-image-uploader/aws.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import (
"github.com/aws/aws-sdk-go/service/s3/s3manager"
"github.com/google/uuid"
"github.com/siderolabs/go-retry/retry"
"github.com/ulikunitz/xz"
"golang.org/x/sync/errgroup"
)

Expand Down Expand Up @@ -171,7 +172,7 @@ func (au *AWSUploader) registerAMIArch(ctx context.Context, region string, svc *

defer source.Close() //nolint:errcheck

image, err := ExtractFileFromTarGz("disk.raw", source)
image, err := xz.NewReader(source)
if err != nil {
return err
}
Expand Down
62 changes: 0 additions & 62 deletions hack/cloud-image-uploader/azure-disk-template.json

This file was deleted.

61 changes: 0 additions & 61 deletions hack/cloud-image-uploader/azure-image-version-template.json

This file was deleted.

Loading

0 comments on commit ac2aff5

Please sign in to comment.