Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix and rewrite Azure cloud image uploader #7512

Closed
smira opened this issue Jul 24, 2023 · 0 comments · Fixed by #7562
Closed

fix and rewrite Azure cloud image uploader #7512

smira opened this issue Jul 24, 2023 · 0 comments · Fixed by #7562
Assignees
@ro11net

Comments

@smira
Copy link
Member

smira commented Jul 24, 2023 •
edited
Loading

  1. Correctly propagate errors back, drop log.Printf() for errors
  2. Drop ARM templates, use native APIs.
  3. Correctly handle restarted runs - re-uploading to the same image tag.
smira added a commit to smira/talos that referenced this issue Jul 26, 2023
@smira
chore: workaround AWS AMI failures, disable Azure uploader
9415ebc 
Fixes siderolabs#7513

AWS image uploads recently consistently fail in some regions, which
blocks the release process. Allow to skip some AMIs if they fail to
upload.

Disable Azure until siderolabs#7512 is resolved.

Signed-off-by: Andrey Smirnov <[email protected]>
@smira smira mentioned this issue Jul 26, 2023
Merged
smira added a commit to smira/talos that referenced this issue Jul 26, 2023
@smira
chore: workaround AWS AMI failures, disable Azure uploader
ffa48ac 
Fixes siderolabs#7513

AWS image uploads recently consistently fail in some regions, which
blocks the release process. Allow to skip some AMIs if they fail to
upload.

Disable Azure until siderolabs#7512 is resolved.

Signed-off-by: Andrey Smirnov <[email protected]>
smira added a commit to smira/talos that referenced this issue Jul 26, 2023
@smira
chore: workaround AWS AMI failures, disable Azure uploader
95a3670 
Fixes siderolabs#7513

AWS image uploads recently consistently fail in some regions, which
blocks the release process. Allow to skip some AMIs if they fail to
upload.

Disable Azure until siderolabs#7512 is resolved.

Signed-off-by: Andrey Smirnov <[email protected]>
(cherry picked from commit ffa48ac)
ro11net added a commit to ro11net/talos that referenced this issue Aug 2, 2023
@ro11net
fix: fix azure portion of cloud uploader
877e562 
Correctly propogate errors back. Drop ARM templates and use native APIs.
Correctly handle restarted runs for creating image versions.
- fixes siderolabs#7512

Signed-off-by: Christian Rolland <[email protected]>
@ro11net ro11net mentioned this issue Aug 2, 2023
Merged
7 tasks
ro11net added a commit to ro11net/talos that referenced this issue Aug 2, 2023
@ro11net
fix: fix azure portion of cloud uploader
8c5224e 
Correctly propagate errors back. Drop ARM templates and use native APIs.
Correctly handle restarted runs for creating image versions. fixes siderolabs#7512.

Signed-off-by: Christian Rolland <[email protected]>
ro11net added a commit to ro11net/talos that referenced this issue Aug 2, 2023
@ro11net
fix: fix azure portion of cloud uploader
42ea2c6 
Correctly propagate errors back. Drop ARM templates and use native APIs.
Correctly handle restarted runs for creating image versions. fixes siderolabs#7512.

Signed-off-by: Christian Rolland <[email protected]>
ro11net added a commit to ro11net/talos that referenced this issue Aug 2, 2023
@ro11net
fix: fix azure portion of cloud uploader
7084f3e 
Correctly propagate errors back. Drop ARM templates and use native APIs.
Correctly handle restarted runs for creating image versions. fixes siderolabs#7512.

Signed-off-by: Christian Rolland <[email protected]>
ro11net added a commit to ro11net/talos that referenced this issue Aug 2, 2023
@ro11net
fix: fix azure portion of cloud uploader
740d612 
Correctly propagate errors back. Drop ARM templates and use native APIs.
Correctly handle restarted runs for creating image versions. fixes siderolabs#7512.

Signed-off-by: Christian Rolland <[email protected]>
ro11net added a commit to ro11net/talos that referenced this issue Aug 2, 2023
@ro11net
fix: fix azure portion of cloud uploader
ccb7692 
Correctly propagate errors back. Drop ARM templates and use native APIs.
Correctly handle restarted runs for creating image versions. fixes siderolabs#7512.

Signed-off-by: Christian Rolland <[email protected]>
ro11net added a commit to ro11net/talos that referenced this issue Aug 2, 2023
@ro11net
fix: fix azure portion of cloud uploader
7888ab9 
Correctly propagate errors back. Drop ARM templates and use native APIs.
Correctly handle restarted runs for creating image versions. fixes siderolabs#7512.

Signed-off-by: Christian Rolland <[email protected]>
ro11net added a commit to ro11net/talos that referenced this issue Aug 2, 2023
@ro11net
fix: fix azure portion of cloud uploader
9f4c2d0 
Correctly propagate errors back. Drop ARM templates and use native APIs.
Correctly handle restarted runs for creating image versions. fixes siderolabs#7512.

Signed-off-by: Christian Rolland <[email protected]>
ro11net added a commit to ro11net/talos that referenced this issue Aug 2, 2023
@ro11net
fix: fix azure portion of cloud uploader
e4ddf28 
Correctly propagate errors back. Drop ARM templates and use native APIs.
Correctly handle restarted runs for creating image versions. fixes siderolabs#7512.

Signed-off-by: Christian Rolland <[email protected]>
ro11net added a commit to ro11net/talos that referenced this issue Aug 2, 2023
@ro11net
fix: fix azure portion of cloud uploader
7166b0c 
Correctly propagate errors back. Drop ARM templates and use native APIs.
Correctly handle restarted runs for creating image versions. fixes siderolabs#7512.

Signed-off-by: Christian Rolland <[email protected]>
ro11net added a commit to ro11net/talos that referenced this issue Aug 3, 2023
@ro11net
fix: fix azure portion of cloud uploader
180a86c 
Correctly propagate errors back. Drop ARM templates and use native APIs.
Correctly handle restarted runs for creating image versions. fixes siderolabs#7512.

Signed-off-by: Christian Rolland <[email protected]>
ro11net added a commit to ro11net/talos that referenced this issue Aug 3, 2023
@ro11net
fix: fix azure portion of cloud uploader
ae89dcb 
Correctly propagate errors back. Drop ARM templates and use native APIs.
Correctly handle restarted runs for creating image versions. fixes siderolabs#7512.

Signed-off-by: Christian Rolland <[email protected]>
smira pushed a commit to smira/talos that referenced this issue Aug 8, 2023
@ro11net @smira
fix: fix azure portion of cloud uploader
eae4507 
Correctly propagate errors back. Drop ARM templates and use native APIs.
Correctly handle restarted runs for creating image versions. fixes siderolabs#7512.

Signed-off-by: Christian Rolland <[email protected]>
(cherry picked from commit ac2aff5)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ro11net ro11net

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fix azure portion of cloud uploader ro11net/talos
2 participants
@smira @ro11net