Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubelet configuration available via machine configuration #4629

Closed
smira opened this issue Dec 1, 2021 · 2 comments · Fixed by #5045
Closed

Kubelet configuration available via machine configuration #4629

smira opened this issue Dec 1, 2021 · 2 comments · Fixed by #5045
Assignees
Milestone

Comments

@smira
Copy link
Member

smira commented Dec 1, 2021

Kubelet command line flags are getting deprecated, and new way to use the config file.

Talos today accepts only extraArgs, so we need a better way to fine-tune kubelet.

We don't want to import whole KubeletConfig as a Go structure into the machine configuration as this will cause unnecessary dependency. We would rather present KubeletConfig as a map[string]interface{}, we skip any validation on Talos side, and simply unmarshal raw data into the KubeletConfig before starting the kubelet. Kubelet will validate its config and error out if it's invalid.

@sergelogvinov
Copy link
Sponsor Contributor

I think a few parameters Talos has to disable change.
like

authentication:
authorization:
staticPodPath:
port:
resolvConf:
systemReserved:
*cgroup*

@smira
Copy link
Member Author

smira commented Feb 2, 2022

Machine Configuration

Validate that user kubelet configuration doesn't try to set values which are blacklisted (always set by Talos).

Controllers

Kubelet configuration controller should prepare defaults (like it does today) and merges them with the user-supplied kubelet configuration building the final kubelet configuration.

node-ip

If the kubelet configuration specifies nodeIP, automatic node IP configuration on Talos should be disabled.

@smira smira added this to the v0.15 milestone Feb 21, 2022
@smira smira self-assigned this Feb 21, 2022
smira added a commit to smira/talos that referenced this issue Feb 24, 2022
Fixes siderolabs#4629

Note: some fields are enforced by Talos and are not overridable.

Signed-off-by: Andrey Smirnov <[email protected]>
apariinaz pushed a commit to nokia/talos that referenced this issue Mar 1, 2022
Fixes siderolabs#4629

Note: some fields are enforced by Talos and are not overridable.

Signed-off-by: Andrey Smirnov <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants