Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Etcd advertisedSubnets #7947

Closed
Tracked by #7561
sergelogvinov opened this issue Nov 9, 2023 · 2 comments · Fixed by #8014
Closed
Tracked by #7561

Etcd advertisedSubnets #7947

sergelogvinov opened this issue Nov 9, 2023 · 2 comments · Fixed by #8014
Assignees

Comments

@sergelogvinov
Copy link
Sponsor Contributor

Bug Report

Description

Etcd advertisedSubnets is the network (filtered ip) which can not exist on the node.
But we use

nodeAddrs, err := safe.ReaderGet[*network.NodeAddress](
NodeAddress (routed) to find the right IP.

Probably we need to use at least nodeIP+platformIP (dnat-ip).
Or check if advertisedSubnets is a single IP use it as is?
What do you think?

Thanks.

Environment

  • Talos version: [1.5.x]
  • Kubernetes version:
  • Platform: azure
@smira
Copy link
Member

smira commented Nov 10, 2023

Yes, probably advertised subnets might come from a more broad range of addresses. Looking for external IP as advertised? It might help if you could describe a scenario.

@sergelogvinov
Copy link
Sponsor Contributor Author

Use case - multi cloud setup without kubespan/ipsec/etc (direct connection).

To make p2p connections between etcd, we need to advertise the external (public) IP, which not exist on the node.
Currently I've added the IP alias to the interface...

PS. I did not notice any error messages when Talos did not find the advertised IP too. Probably we need to add error messages at boot time too.

Thanks.

@smira smira self-assigned this Dec 1, 2023
smira added a commit to smira/talos that referenced this issue Dec 1, 2023
Fixes siderolabs#7947

This way etcd advertisted address can be picked from the `external IPs`
of the machine.

Signed-off-by: Andrey Smirnov <[email protected]>
smira added a commit to smira/talos that referenced this issue Dec 1, 2023
Fixes siderolabs#7947

This way etcd advertised address can be picked from the `external IPs`
of the machine.

Signed-off-by: Andrey Smirnov <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants