Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 installer for sbc is broken in master #8009

Closed
Tracked by #7561
nberlee opened this issue Nov 30, 2023 · 1 comment · Fixed by #8015
Closed
Tracked by #7561

🐛 installer for sbc is broken in master #8009

nberlee opened this issue Nov 30, 2023 · 1 comment · Fixed by #8015
Assignees

Comments

@nberlee
Copy link
Sponsor Contributor

nberlee commented Nov 30, 2023

Bug Report

Since cbe6e76 dtb and bin have a relative path. This works great for imager but broke the talosctl upgrade installer.

(when adding the full path back, it works, but that is probably not a solution for imager)

Logs

2023/11/30 21:16:12 installing U-Boot for "turing_rk1"
XFS (mmcblk0p3): Unmounting Filesystem c987c675-7c7e-481b-a01c-7f07948338f7
Error: open turing_rk1/u-boot-rockchip.bin: no such file or directory
Usage:
  installer install [flags]

Flags:
  -h, --help   help for install

Global Flags:
      --arch string                    The target architecture (default "arm64")
      --board string                   The value of talos.board (default "none")
      --bootloader                     Deprecated: no op (default true)
      --config string                  The value of talos.config
      --disk string                    The path to the disk to install to
      --extra-kernel-arg stringArray   Extra argument to pass to the kernel
      --force                          Indicates that the install should forcefully format the partition
      --meta metaValueSlice            A key/value pair for META (default [])
      --platform string                The value of talos.platform
      --upgrade                        Indicates that the install is being performed by an upgrade
      --zero                           Indicates that the install should write zeros to the disk before installing

open turing_rk1/u-boot-rockchip.bin: no such file or directory
[talos] task upgrade (1/1): failed: task "upgrade" failed: exit code 1

Environment

  • Talos version: v1.6.0-alpha.2
  • Kubernetes version: [kubectl version --short]
  • Platform:
@smira
Copy link
Member

smira commented Dec 1, 2023

Thank you, will get it fixed!

@smira smira changed the title installer for sbc is broken in master 🐛 installer for sbc is broken in master Dec 1, 2023
@smira smira self-assigned this Dec 1, 2023
smira added a commit to smira/talos that referenced this issue Dec 1, 2023
The problem was that bootloaders were correctly picking up defaults for
`installer` mode (vs. `imager` mode), but DTB and other SBC stuff wasn't
properly initialized, so installing on SBC fails.

Now all options are properly initialized with defaults early in the
process.

Fixes siderolabs#8009

Signed-off-by: Andrey Smirnov <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants