Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 talosctl edit machineconfig enters a loop #8424

Closed
smira opened this issue Mar 12, 2024 · 1 comment · Fixed by #8435
Closed

🐛 talosctl edit machineconfig enters a loop #8424

smira opened this issue Mar 12, 2024 · 1 comment · Fixed by #8435
Assignees

Comments

@smira
Copy link
Member

smira commented Mar 12, 2024

Sometimes the command enters a loop, showing the editor with old contents without applying the config.

@utkuozdemir utkuozdemir self-assigned this Mar 12, 2024
@utkuozdemir
Copy link
Member

Context: https://taloscommunity.slack.com/archives/CMARMBC4E/p1707866739306199

Unable to reproduce so far.

utkuozdemir added a commit to utkuozdemir/talos that referenced this issue Mar 14, 2024
We now remove the machine config with the id `maintenance` when we are done with it - when the maintenance service is shut down.

Closes siderolabs#8424, where in some configurations there would be machine configs with both `v1alpha1` and `maintenance` IDs present, causing the `talosctl edit machineconfig` to loop twice and causing confusion.

Signed-off-by: Utku Ozdemir <[email protected]>
utkuozdemir added a commit to utkuozdemir/talos that referenced this issue Mar 14, 2024
We now remove the machine config with the id `maintenance` when we are done with it - when the maintenance service is shut down.

Closes siderolabs#8424, where in some configurations there would be machine configs with both `v1alpha1` and `maintenance` IDs present, causing the `talosctl edit machineconfig` to loop twice and causing confusion.

Signed-off-by: Utku Ozdemir <[email protected]>
smira pushed a commit to smira/talos that referenced this issue Mar 20, 2024
We now remove the machine config with the id `maintenance` when we are done with it - when the maintenance service is shut down.

Closes siderolabs#8424, where in some configurations there would be machine configs with both `v1alpha1` and `maintenance` IDs present, causing the `talosctl edit machineconfig` to loop twice and causing confusion.

Signed-off-by: Utku Ozdemir <[email protected]>
(cherry picked from commit 7376f34)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants