Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't seem to remove node.kubernetes.io/exclude-from-external-load-balancers from machine.nodeLabels #9325

Closed
Tracked by #8484
michaelbeaumont opened this issue Sep 14, 2024 · 2 comments · Fixed by #9329
Closed
Tracked by #8484

Can't seem to remove node.kubernetes.io/exclude-from-external-load-balancers from machine.nodeLabels #9325

michaelbeaumont opened this issue Sep 14, 2024 · 2 comments · Fixed by #9329
Assignees
@smira

Comments

@michaelbeaumont
Copy link
Contributor

Bug Report

In spite of the following patch contents:

machine:
  nodeLabels:
    node.kubernetes.io/exclude-from-external-load-balancers:
      $patch: delete

apparently being cleanly applied, the node label is not removed from the config and from the Kubernetes node.

Logs

None

Environment

  • Talos version: v1.8.0-beta.0, terraform provider 0.6.0-beta.0
  • Kubernetes version: v1.31.0
  • Platform: metal
@smira smira mentioned this issue Sep 16, 2024
Closed
@smira smira self-assigned this Sep 16, 2024
@michaelbeaumont
Copy link
Contributor Author

One idea here might be to not apply this label by default if:

cluster:
  allowSchedulingOnControlPlanes: true

@smira
Copy link
Member

smira commented Sep 16, 2024

One idea here might be to not apply this label by default if:

This goes the other way around, the base config is generated before the patches are applied, so Talos doesn't know if it got enabled or not.

@smira smira mentioned this issue Sep 16, 2024
Merged
smira added a commit to smira/talos that referenced this issue Sep 21, 2024
@smira
fix: strategic merge patch delete for map keys
3207693 
When a map key is deleted, it should be deleted as a whole.
Before the fix it was zeroing out map value by key.

Fixes siderolabs#9325

Signed-off-by: Andrey Smirnov <[email protected]>
(cherry picked from commit 18daedb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smira smira

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: strategic merge patch delete for map keys smira/talos
2 participants
@smira @michaelbeaumont