fix: do not panic in merge.Merge if map value is nil.
#8022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DmitriyMV
force-pushed
the
fix-nil-check
branch
from
bb15828
to
658689a
Compare
smira
approved these changes
Dec 4, 2023
Checking for `zeroValue` is not enough when accessing `map[string]any`. Closes siderolabs#8005 Signed-off-by: Dmitriy Matrenichev <[email protected]>
DmitriyMV
force-pushed
the
fix-nil-check
branch
from
658689a
to
6329222
Compare
|
/m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking for
zeroValueis not enough when accessingmap[string]any.Closes #8005