feat: support environment in ExtensionServiceConfig
#8273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frezbo
force-pushed
the
feat/ext-config-env-support
branch
from
5b1bbec
to
34e4f2f
Compare
frezbo
force-pushed
the
feat/ext-config-env-support
branch
4 times, most recently
from
e71db82
to
78b4138
Compare
|
/promote integration-extensions |
Unix4ever
approved these changes
Feb 8, 2024
smira
reviewed
Feb 8, 2024
smira
reviewed
Feb 8, 2024
pkg/machinery/config/types/extensionservicesconfig/extension_services_config.go
Outdated
Show resolved
Hide resolved
smira
approved these changes
Feb 8, 2024
frezbo
force-pushed
the
feat/ext-config-env-support
branch
6 times, most recently
from
f0a933c
to
b8e2c18
Compare
frezbo
changed the title
ExtensionServicesConfigExtensionServiceConfig
frezbo
force-pushed
the
feat/ext-config-env-support
branch
from
b8e2c18
to
071e078
Compare
|
/promote integration-extensions |
smira
reviewed
Feb 15, 2024
| // ConfigFiles implements config.ExtensionServiceConfig interface. | ||
| func (e *ServiceConfigV1Alpha1) ConfigFiles() []config.ExtensionServiceConfigFile { | ||
| return xslices.Map(e.ServiceConfigFiles, func(c ConfigFile) config.ExtensionServiceConfigFile { | ||
| return &ConfigFile{ |
There was a problem hiding this comment.
that's a nit, but looks like we could either do return &c here, or we could define methods Content() and MountPath() on non-pointer ConfigFile so we can avoid this copying
we still need .Map() to convert to the interface type though
smira
approved these changes
Feb 15, 2024
frezbo
force-pushed
the
feat/ext-config-env-support
branch
from
071e078
to
fef3995
Compare
Support setting extension services environment variables in `ExtensionServiceConfig` document. Refactor `ExtensionServicesConfig` -> `ExtensionServiceConfig` and move extensions config under `runtime` pkg. Fixes: siderolabs#8271 Signed-off-by: Noel Georgi <[email protected]>
frezbo
force-pushed
the
feat/ext-config-env-support
branch
from
fef3995
to
15e8bca
Compare
frezbo
added a commit
to frezbo/extensions
that referenced
this pull request
Feb 15, 2024
Use `ExtensionServiceConfig` document for extensions using `.machine.files` or `environmentFile`. Ref: siderolabs/talos#8273 Signed-off-by: Noel Georgi <[email protected]>
|
/m |
frezbo
added a commit
to frezbo/extensions
that referenced
this pull request
Feb 15, 2024
Use `ExtensionServiceConfig` document for extensions using `.machine.files` or `environmentFile`. Ref: siderolabs/talos#8273 Signed-off-by: Noel Georgi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support setting extension services environment variables in
ExtensionServiceConfigdocument.Fixes: #8271